Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR batch 3 #709

Closed
1 task done
nponeccop opened this issue Apr 10, 2023 · 7 comments
Closed
1 task done

PR batch 3 #709

nponeccop opened this issue Apr 10, 2023 · 7 comments

Comments

@nponeccop
Copy link
Contributor

nponeccop commented Apr 10, 2023

Duplicates

  • I have searched the existing issues

Summary 💡

This is a current batch we are merging. It's frozen, no new PRs come in, although we do merge very simple or critical PRs out of band. The new PRs go to #1015

Clean Merge🌈

Needs Discussion


These are the PRs currently classified as unmergeable (by me, I'm not a maintainer), due to various reasons. I will add more PRs as we are preparing the Batch 3.

Major Features

Require Benchmark

Need splitting

Motivation 🔦

We need to merge all the simple requests first.

@blankster
Copy link
Contributor

@nponeccop love your "batches" and how you support the maintainer 👏

@nponeccop nponeccop mentioned this issue Apr 10, 2023
1 task
@Artemonim
Copy link
Contributor

@nponeccop maybe you can ask Maintainer for the Issue Watcher role and use label system for this?
It would greatly improve the navigation of issues and PRs

@nponeccop
Copy link
Contributor Author

There is already a discussion at #469, you can add your suggestion there.

@nponeccop
Copy link
Contributor Author

@Torantulino I see some PRs were merged out of band. After finishing with the important PRs can we get back to the 5 remaining PRs in the Batch 2? It's important to merge the PRs FIFO (except the high-priority ones) so that the authors are motivated to do the rebasing/conflict resolution. We need to give them an idea that once their request is accepted, it will get merged in the next batch. If the requests are non-mergeable for some reason we need to clearly indicate the reason we postpone, close the batch and re-schedule the remaining requests to a different batch.

I heard there was a conference call yesterday, what are the decisions taken there regarding the PR flow if any?

@Artemonim
Copy link
Contributor

Can I participate with #889 ? 👉👈😳

@nponeccop
Copy link
Contributor Author

@Artemonim Done.

For future visitors, the right way to do it is to tag me. I read all Auto-GPT updates in email. Or just ask for a review.

@p-i- p-i- mentioned this issue Apr 12, 2023
@nponeccop nponeccop changed the title PR batch 3 (WIP) PR batch 3 Apr 12, 2023
@nponeccop
Copy link
Contributor Author

The text below, is obviously, courtesy to ChatGPT.

Batch 3 has been closed, and we've moved onto Batch 4 (#1015), which is currently frozen. Any new pull requests will be directed to Batch 5 (#1162).

To keep things organized, we've added labeling to our pull requests. If we're not ready to merge a request yet, we label it as "need-discussion", "enhancement", or "question". Today, our second merger, @p-i-, is finally able to work at full speed.

Any remaining unlabeled issues from Batch 3 will be moved to Batch 4, while any labeled issues will remain here until they are de-labeled. This is because we want to merge all the smaller pull requests first, before moving on to larger architectural improvements and technical debt. Our current version isn't very stable even with its limited set of commands, due to well-known JSON parsing issues, as well as other usability and reliability issues. Therefore, we need to fix these issues first.

We set up CI today and will be increasing the strictness of flake8 every day, so be prepared to fix more linting issues. We now have a stable branch which is updated once a day and is smoke-tested by the maintainers. The master branch is quite volatile, and we encounter daily breakages that we fix at the end of the day before releasing. As a developer, you can help us by testing the intermediate master branch state for breakages. If you're a general user, you can get a general idea of the progress by downloading a versioned GitHub release or cloning a tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants