-
Notifications
You must be signed in to change notification settings - Fork 44.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop requirements.txt in favor of pyproject.toml and add autogpt
entrypoint
#1955
Conversation
// Use 'postCreateCommand' to run commands after the container is created. | ||
// "postCreateCommand": "pip3 install --user -r requirements.txt", | ||
// "postCreateCommand": "pip3 install --user .", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably doesnt work
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
1 similar comment
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
@jayceslesar can you resolve the merge conflicts and make sure it correctly handles the conditional dependencies? |
If we're going this direction (which i like a lot) why not just switch to poetry completely and use a poetry.lock for dependency management? way prefer how poetry handles installs and virtual environments |
@Pwuts is this still something you guys want to implement? I like the poetry suggestion mentioned above...getting the dependencies not to exist in docker may be tricky...excluding dependencies in extras is not really feasible as they are "extras" |
I think so, yes. It's just that we also have more pressing todos so we haven't gotten to discussing this yet. |
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
I know this is a bit old but if you're interested in getting this merged, so am I |
If we want to get this merged, we'll probably have to do it ourselves |
Fair, at this point, its probably worth just reopening from scratch just to avoid conflicts |
Duplicate of #1102 |
Background
The idea here is to drop requirements.txt in favor of pyproject.toml which is the preferred way to handle projects as scale such as this. This opens up the door to a more unified CI as time passes. This also allows the ability to split out dev dependencies and application dependencies in the future if needed. This also adds an
autogpt
entrypoint so users no longer have to runpython3 -m autogpt
for clarity.Changes
Change documentation around installing to just
pip install .
andpip install -e .
if needed. No setup should change other than that and relevant docker commands were changed to match this.Documentation
The README.md was changed in order to show that the requirements.txt is not needed anymore and one can simply
pip install .
and also add an entrypoint so users of the application level code can just runautogpt
with the same CLI exposed behind the previous way of invoking the application.Test Plan
Testing shouldnt really need to be done
PR Quality Checklist
This doesn't change any functional code only how the code/application is installed and invoked.