-
Notifications
You must be signed in to change notification settings - Fork 44.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to poetry #1102
Migrate to poetry #1102
Conversation
@nponeccop please have a look |
You're fixing all the version numbers in poetry. Isn't half the point of poetry that it can auto-figure-out compatible version numbers? |
@p-i- you're right. We can:
Whats your take on this? |
I will sync the fork once we agree on the version handling per above. At the rate this codebase is changing it will look totally different once this PR is approved for merge. =) |
@p-i- @richbeales any chance of input on the version resolution question so I can rebase this PR onto the latest master? |
@rickythefox My vote would be for letting Poetry figure the versions out, rather than pinning versions. Yes it's possible that some version update could cause an issue, but it feels so much cleaner to keep it floating and fix in the unusual event of a conflict. How about we stick with (1) for now? |
@p-i- perfect, then my last update handled that II will rebase within a free hours |
2eeae3f
to
07b8a1d
Compare
Updated and pushed. Note that I pinned |
@rickythefox
Please can you add them |
Conflicting files |
Fixed and added pymilvus and redis. Dev dependencies are not installed when building docker image. @richbeales |
@rickythefox thank you very much ! there was some issues on some pipelines plus recent dependencies commented so we kept your work commits and created |
Hey @rickythefox we started consolidating your pr into this PR. Then I started thinking about how it could affect regular users and this is my concern:
So I am not saying no. I am just saying I am not so sure about this being a good move for all users, including non developers / tinkerers / dev amateurs. |
@merwanehamadi @BillSchumacher well, the way I see it poetry will be more user-friendly.
|
@merwanehamadi I'm coming to this issue trying to package this for a linux distribution. |
I am fine if we move forward with that, I love poetry, and I was the one pushing for it. As long as we have all users in mind, not just maintainers. There aren't many open source projects like this that reached such a wide range of users persona |
@rickythefox CI is red |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
@nponeccop should be ok now |
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
@nponeccop so will this be merged or should I close the PR? |
I think yes, it will probably be merged, just not now. Plugins are in the works. It's a huge change so we would like to release them first. Probably tonight. |
@nponeccop ok, I'll hold off merging any conflicts until you say go. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
Any news on poetry adoption? |
Getting this up-to-date was too complicated, so I started over in #5219. I've credited you as co-author @rickythefox :) |
Inspired by #1102 * Migrate AutoGPT agent to poetry Co-authored-by: rickythefox <richard@ginzburg.se> * Rewrite automatic dependency check (check_requirements.py) for poetry * Sort dependencies * Add instructions for poetry to README
Background
Based on #367
Changes
Migrate to poetry for requirements management.
Documentation
README.md is updated to reflect the change.
Test Plan
PR Quality Checklist