add edge to browser options for selenium #1988
Conversation
|
While you're at it can you also add opera? Just to complete everything lol |
|
I can look it up, but I can't test it myself. Also, I just noticed a few changes that aren't mine. Mostly likely from the last pull I did. Still new to PR's and first time doing it from VS Code. I'll try to fix. |
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
github-actions
bot
added
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
2 similar comments
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
Not recommended. Create a separate PR. See:
|
|
Note this looks like a useful change to be reviewed/integrated despite the ongoing re-arch effort, it's primarily config-level, with very few code changes. So definitely do consider for review/integration to help close some PRs. Thanks |
|
While, I do agree that this probably has no affects on the rearch, as chrome is available at the moment, I think this is low priority until after the rearch. This could also open a whole new can of worms with webdriver. This repo keeps running into problems with getting chromedriver to cooperate. Adding msedgedriver to the mix probably isn't a good idea right now. Though I do think we still inevitably need this. I just feel like a better time to propose this would be after the rearch and after the issues with chromedriver have been mitigated. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
github-actions
bot
added
size/s
and removed
conflicts
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1988 +/- ##
==========================================
- Coverage 60.84% 60.81% -0.03%
==========================================
Files 73 73
Lines 3315 3318 +3
Branches 543 544 +1
==========================================
+ Hits 2017 2018 +1
- Misses 1160 1161 +1
- Partials 138 139 +1
☔ View full report in Codecov by Sentry. |
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
|
Closing in favor of #3058 |
Background
I received errors related to selenium not locating the default chrome binary.
Instead of installing it and possibly troubleshooting file paths, I wanted to use my current browser.
Changes
Added 'edge' as a browser option for selenium.
Documentation
Updated .env.template to reflect the additional option. Kept changes consistent with existing code.
Test Plan
Auto-GPT has opened a new MS Edge browser instance, navigated to the provided URL, scraped the content, and closed the browser instance. This has successfully occurred in multiple runs without related errors.
PR Quality Checklist