Add Edge browser support using EdgeChromiumDriverManager #3058

karimhabush · 2023-04-23T21:12:28Z

Background

This pull request aims to add support for the Edge browser in the web_selenium.py commands. The change will allow users to leverage the Edge browser while using Selenium for web automation tasks, in addition to the existing supported browsers.

Changes

Imported EdgeChromiumDriverManager from the webdriver_manager.microsoft package.
Added EdgeOptions to the available browser options.
Updated the driver initialization logic to use the Edge driver when the configured browser is set to "edge".

Documentation

The changes made in this pull request are documented within the .env.template file.

Test Plan

Set the USE_WEB_BROWSER variable to edge within the file .env.template.
Rename the file .env.template to .env
Run the script and provide a prompt that requires the command browse_website to ensure that the Edge browser is launched and web scraping tasks are performed without any issues.
Test the same script with other browsers (Chrome, Safari, and Firefox) to ensure that the existing functionality remains intact.

PR Quality Checklist

My pull request is atomic and focuses on a single change.
I have thoroughly tested my changes with multiple different prompts.
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes

codecov · 2023-04-23T21:15:37Z

Codecov Report

Patch coverage has no change and project coverage change: -8.55 ⚠️

Comparison is base (aedd288) 49.20% compared to head (1cd730f) 40.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3058      +/-   ##
==========================================
- Coverage   49.20%   40.65%   -8.55%     
==========================================
  Files          63       63              
  Lines        3014     3018       +4     
  Branches      496      497       +1     
==========================================
- Hits         1483     1227     -256     
- Misses       1411     1719     +308     
+ Partials      120       72      -48

Impacted Files	Coverage Δ
autogpt/commands/web_selenium.py	`0.00% <0.00%> (ø)`

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ntindle · 2023-04-23T21:34:14Z

Can you run the linter (black) and issort to fix the linter errors

karimhabush · 2023-04-23T21:48:35Z

Can you run the linter (black) and issort to fix the linter errors

Sure thing!

vercel · 2023-05-02T02:55:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)			May 13, 2023 9:22pm

codecov · 2023-05-02T03:00:27Z

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02 ⚠️

Comparison is base (2f7beeb) 60.84% compared to head (9b91cfc) 60.83%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3058      +/-   ##
==========================================
- Coverage   60.84%   60.83%   -0.02%     
==========================================
  Files          73       73              
  Lines        3315     3319       +4     
  Branches      543      544       +1     
==========================================
+ Hits         2017     2019       +2     
- Misses       1160     1161       +1     
- Partials      138      139       +1

Impacted Files	Coverage Δ
autogpt/commands/web_selenium.py	`84.44% <50.00%> (-1.61%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

p-i- · 2023-05-05T00:54:07Z

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

Boostrix · 2023-05-07T07:07:52Z

Note this looks like a useful change to be reviewed/integrated despite the ongoing re-arch effort, it's primarily config-level, with very few code changes (and those primarily are about supporting a new option). So definitely do consider for review/integration to help close some PRs. Thanks

anonhostpi · 2023-05-07T07:38:06Z

IMO, I don't recommend rn.

#1988 (comment)

anonhostpi · 2023-05-07T07:40:45Z

Related: issues regarding web automation

@collijk

* Feature/tighten up ci pipeline (#3700) * Fix docker volume mounts (#3710) Co-authored-by: Reinier van der Leer <github@pwuts.nl> Co-authored-by: Nicholas Tindle <nick@ntindle.com> * Feature/enable intuitive logs for community challenge step 1 (#3695) * Feature/enable intuitive logs summarization (#3697) * Move task_complete command out of prompt (#3663) * feat: move task_complete command out of prompt * fix: formatting fixes * Add the shutdown command to the test agents * tests: update test vcrs --------- Co-authored-by: James Collins <collijk@uw.edu> * Allow users to Disable Commands via the .env (#3667) * Document Disabling command categories (#3669) * feat: move task_complete command out of prompt * fix: formatting fixes * feat: add command disabling * docs: document how to disable command categories * Enable denylist handling for plugins (#3688) Co-authored-by: Luke Kyohere <lkyohere@mfsafrica.com> Co-authored-by: Nicholas Tindle <nick@ntindle.com> * Fix call to `plugin.post_planning` (#3414) Co-authored-by: Nicholas Tindle <nick@ntindle.com> * create information retrieval challenge a (#3770) Co-authored-by: Richard Beales <rich@richbeales.net> * fix typos (#3798) * Update run.bat (#3783) Co-authored-by: Richard Beales <rich@richbeales.net> * Update run.sh (#3752) Co-authored-by: Richard Beales <rich@richbeales.net> * ADD: Bash block in the contributing markdown (#3701) Co-authored-by: Richard Beales <rich@richbeales.net> * BUGFIX: Selenium Driver object reference was included in the browsing results for some reason (#3642) * * there is really no need to return the reference to the Selenium driver along with the text summary and list of links. * * removing unused second return value from browse_website() * * updated cassette * * updated YAML cassette for test_browse_website * * after requirements reinstall, another update YAML cassette for test_browse_website * * another update YAML cassette for test_browse_website, only as a placholder commit to trigger re-testing due to some docker TCP timeout issue * * another update YAML cassette for test_browse_website --------- Co-authored-by: batyu <batyu@localhost> * Update CONTRIBUTING.md * Self feedback Improvement (#3680) * Improved `Self-Feedback` * minor tweak * Test: Updated `test_get_self_feedback.py` * community challenges in the wiki (#3764) * Update README.md * Update PULL_REQUEST_TEMPLATE.md Added link to wiki Contributing page * Add link to wiki Contributing page * fix * Add link to wiki page on Contributing * Implement Logging of User Input in logs/Debug Folder (#3867) * Adds USER_INPUT_FILE_NAME * Update agent.py * Update agent.py Log only if console_input is not the authorise_key * Reformatting * add information retrieval challenge to the wiki (#3876) * add code owners policy (#3981) * add code owners * added @ to codeowners * switched to team ownership * Memory Challenge C (#3908) * Memory Challenge C * Working cassettes * Doc fixes * Linting and doc fix * Updated cassette * One more cassette try --------- Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> * memory challenge c inconsistent (#3985) * Improve & fix memory challenge docs. (#3989) Co-authored-by: Kaan Osmanagaoglu <kaano@questps.com.au> * Feature/centralize prompt (#3990) Co-authored-by: xiao.hu <454292663@qq.com> * Use correct reference to prompt_generator in autogpt/llm/chat.py (#4011) * fix typos (#3998) Co-authored-by: Minfeng Lu <minfenglu@Minfengs-MacBook-Pro.local> Co-authored-by: Richard Beales <rich@richbeales.net> * fix typo in the getting started docs (#3997) Co-authored-by: Richard Beales <rich@richbeales.net> * Fix path to workspace directory in setup guide (#3927) Co-authored-by: Nicholas Tindle <nick@ntindle.com> * document that docker-compose 1.29.0 is minimally required (#3963) Co-authored-by: Nicholas Tindle <nick@ntindle.com> * Integrate pytest-xdist Plugin for Parallel and Concurrent Testing (#3870) * Adds pytest-parallel dependencies * Implement pytest-parallel for faster tests * Uses pytest-xdist * Auto number of workers processes * Update ci.yml --------- Co-authored-by: Nicholas Tindle <nick@ntindle.com> * explain temperature setting in env file (#4140) Co-authored-by: Richard Beales <rich@richbeales.net> * Catch JSON error in summary_memory.py (#3996) Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Update duckduckgo dependency - min should be 2.9.5 (#4142) Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Update Dockerfile - add missing scripts and plugins directories. (#3706) Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Updated memory setup links (#3829) Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Parse package versions so upgrades can be forced (#4149) * parse package versions so upgrades can be forced * better version from @collijk * fix typo in autopgt/agent/agent.py (#3747) Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> Co-authored-by: Richard Beales <rich@richbeales.net> Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Fix `milvus_memory_test.py` mock `Config` (#3424) Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Implemented showing the number of preauthorised commands left. #1035 (#3322) Co-authored-by: mayubi <marwand@ayubi-it.de> Co-authored-by: Nicholas Tindle <nick@ntindle.com> Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Challenge: Kubernetes and documentation (#4121) * challenge_kubes_and_readme * docs * testing * black and isort * revision * lint * comments * blackisort * docs * docs * deleting_cassette * suggestions * misspelling_errors --------- Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> * Make sdwebui tests pass (when SD is running) (#3721) Co-authored-by: Nicholas Tindle <nick@ntindle.com> * Add Edge browser support using EdgeChromiumDriverManager (#3058) Co-authored-by: Nicholas Tindle <nick@ntindle.com> Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Added --install-plugin-deps to Docker (#4151) Co-authored-by: Nicholas Tindle <nick@ntindle.com> * Feature/basic proxy (#4164) * basic proxy (#54) * basic proxy (#55) * basic proxy * basic proxy * basic proxy * basic proxy * add back double quotes * add more specific files * write file * basic proxy * Put back double quotes * test new CI (#4168) * test new CI * test new CI * remove double quotes * Feature/test new ci pipeline 2 (#4169) * test new CI * remove double quotes * make it a variable * make it a variable * Test New CI Pipeline (#4170) * introduce dummy prompt change * introduce dummy prompt change * empty commit * empty commit * empty commit * push to origin repo * add s to quote * Feature/fix rate limiting issue Step 1 (#4173) * temporarilly remove 3.11 * add back 3.11 (#4185) * Revert "Put back 3.11 until it's removed as a requirement" (#4191) --------- Co-authored-by: Reinier van der Leer <github@pwuts.nl> Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> Co-authored-by: Peter Petermann <ppetermann80@googlemail.com> Co-authored-by: Nicholas Tindle <nick@ntindle.com> Co-authored-by: James Collins <collijk@uw.edu> Co-authored-by: Luke K <2609441+pr-0f3t@users.noreply.github.com> Co-authored-by: Luke Kyohere <lkyohere@mfsafrica.com> Co-authored-by: Robin Richtsfeld <robin.richtsfeld@gmail.com> Co-authored-by: RainRat <rainrat78@yahoo.ca> Co-authored-by: itsmarble <130370814+itsmarble@users.noreply.github.com> Co-authored-by: Ambuj Pawar <pawar.ambuj@gmail.com> Co-authored-by: bszollosinagy <4211175+bszollosinagy@users.noreply.github.com> Co-authored-by: batyu <batyu@localhost> Co-authored-by: Pi <sunfish7@gmail.com> Co-authored-by: AbTrax <45964236+AbTrax@users.noreply.github.com> Co-authored-by: Andres Caicedo <73312784+AndresCdo@users.noreply.github.com> Co-authored-by: Douglas Schonholtz <15002691+dschonholtz@users.noreply.github.com> Co-authored-by: Kaan <kaanixir@gmail.com> Co-authored-by: Kaan Osmanagaoglu <kaano@questps.com.au> Co-authored-by: xiao.hu <454292663@qq.com> Co-authored-by: Tomasz Kasperczyk <tomaszikasperczyk@gmail.com> Co-authored-by: minfeng-ai <42948406+minfenglu@users.noreply.github.com> Co-authored-by: Minfeng Lu <minfenglu@Minfengs-MacBook-Pro.local> Co-authored-by: Shlomi <81581678+jit-shlomi@users.noreply.github.com> Co-authored-by: Itai Steinherz <itaisteinherz@gmail.com> Co-authored-by: Boostrix <119627414+Boostrix@users.noreply.github.com> Co-authored-by: Kristian Jackson <kristian.jackson@gmail.com> Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> Co-authored-by: Eduardo Salinas <edus@microsoft.com> Co-authored-by: prom3theu5 <dave@simcube.co.uk> Co-authored-by: dominic-ks <contact@bedevious.co.uk> Co-authored-by: andrey13771 <51243350+andrey13771@users.noreply.github.com> Co-authored-by: Marwand Ayubi <98717667+xhypeDE@users.noreply.github.com> Co-authored-by: mayubi <marwand@ayubi-it.de> Co-authored-by: Media <12145726+rihp@users.noreply.github.com> Co-authored-by: Cenny <cwenner@gmail.com> Co-authored-by: Abdelkarim Habouch <37211852+karimhabush@users.noreply.github.com>

karimhabush and others added 2 commits April 23, 2023 21:29

Add Edge Browser support for Selenium

ac44f98

Merge branch 'Significant-Gravitas:master' into master

b26c651

github-actions bot added the size/xs label Apr 23, 2023

ntindle previously approved these changes Apr 23, 2023

View reviewed changes

Merge branch 'master' into master

3e320d0

Merge branch 'master' into master

663b4bc

Fix lint errors

bc66139

karimhabush dismissed ntindle’s stale review via bc66139 April 23, 2023 22:21

ntindle added 2 commits April 23, 2023 17:22

Merge branch 'master' into master

32edc33

Merge branch 'master' into master

1cd730f

hdkiller assigned ntindle Apr 24, 2023

hdkiller mentioned this pull request Apr 24, 2023

Add support for more web broswers. #3027

Closed

1 task

Merge branch 'master' into master

565e46c

github-actions bot added size/s and removed size/xs labels May 2, 2023

vercel bot temporarily deployed to Preview May 2, 2023 02:55 Inactive

ntindle added this to the v0.3.1 Release milestone May 2, 2023

ntindle added 2 commits May 1, 2023 22:49

Merge branch 'master' into master

3371add

Merge branch 'master' into master

8462d02

vercel bot temporarily deployed to Preview May 3, 2023 02:30 Inactive

Merge branch 'master' into master

c2db05f

vercel bot temporarily deployed to Preview May 4, 2023 02:59 Inactive

Merge branch 'master' into master

8da126d

vercel bot temporarily deployed to Preview May 13, 2023 19:59 Inactive

Merge branch 'master' into master

9b91cfc

k-boikov mentioned this pull request May 13, 2023

add edge to browser options for selenium #1988

Closed

5 tasks

k-boikov approved these changes May 13, 2023

View reviewed changes

k-boikov merged commit b958386 into Significant-Gravitas:master May 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Edge browser support using EdgeChromiumDriverManager #3058

Add Edge browser support using EdgeChromiumDriverManager #3058

karimhabush commented Apr 23, 2023 •

edited

Loading

codecov bot commented Apr 23, 2023 •

edited

Loading

ntindle commented Apr 23, 2023

karimhabush commented Apr 23, 2023

vercel bot commented May 2, 2023 •

edited

Loading

codecov bot commented May 2, 2023 •

edited

Loading

p-i- commented May 5, 2023

Boostrix commented May 7, 2023

anonhostpi commented May 7, 2023

anonhostpi commented May 7, 2023 •

edited

Loading

Add Edge browser support using EdgeChromiumDriverManager #3058

Add Edge browser support using EdgeChromiumDriverManager #3058

Conversation

karimhabush commented Apr 23, 2023 • edited Loading

Background

Changes

Documentation

Test Plan

PR Quality Checklist

codecov bot commented Apr 23, 2023 • edited Loading

Codecov Report

ntindle commented Apr 23, 2023

karimhabush commented Apr 23, 2023

vercel bot commented May 2, 2023 • edited Loading

codecov bot commented May 2, 2023 • edited Loading

Codecov Report

p-i- commented May 5, 2023

Boostrix commented May 7, 2023

anonhostpi commented May 7, 2023

anonhostpi commented May 7, 2023 • edited Loading

karimhabush commented Apr 23, 2023 •

edited

Loading

codecov bot commented Apr 23, 2023 •

edited

Loading

vercel bot commented May 2, 2023 •

edited

Loading

codecov bot commented May 2, 2023 •

edited

Loading

anonhostpi commented May 7, 2023 •

edited

Loading