A number of refactorings #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactorings including f-strings, returning immediate inline variables, hoisting, list comprehensions, and conditional rearranging.
nponeccop
suggested changes
Apr 10, 2023
There was a problem hiding this comment.
Split them up. Some of the refactorings are a matter of taste, e.g. retValue = foo; return retValue isn't redundant because you can easily add logging.
So apply one refactoring per PR to entire codebase, don't mix strings and return values together,
And it got out of date, so resolve the conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactorings including f-strings, returning immediate inline variables, hoisting, list comprehensions, and conditional rearranging.