Fix call to `plugin.post_planning` #3414

Androbin · 2023-04-27T16:49:38Z

Background

Expected 1 positional argument

Pylance: reportGeneralTypeIssues

Signature

(method) def post_planning(
    self: Self@AutoGPTPluginTemplate,
    response: str
) -> str

Changes

Before

plugin.post_planning(self, assistant_reply_json)

# equivalent to
type(plugin).post_planning(plugin, self, assistant_reply_json)`
                  # types: AutoGPTPluginTemplate, Agent, str

After

plugin.post_planning(assistant_reply_json)

# equivalent to
type(plugin).post_planning(plugin, assistant_reply_json)
                  # types: AutoGPTPluginTemplate, str

Documentation

Test Plan

PR Quality Checklist

My pull request is atomic and focuses on a single change.
I have thoroughly tested my changes with multiple different prompts.
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes

vercel · 2023-04-27T16:49:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 4, 2023 2:40am

codecov · 2023-04-27T16:55:10Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (a48f26c) 60.96% compared to head (c899ac2) 60.96%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3414   +/-   ##
=======================================
  Coverage   60.96%   60.96%           
=======================================
  Files          72       72           
  Lines        3302     3302           
  Branches      542      542           
=======================================
  Hits         2013     2013           
  Misses       1151     1151           
  Partials      138      138

Impacted Files	Coverage Δ
autogpt/agent/agent.py	`48.63% <0.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ntindle · 2023-04-29T17:48:41Z

Please fill out the description of the PR

bobisme · 2023-04-29T23:39:51Z

this looks like a simple fix for a legit bug

Co-authored-by: Nicholas Tindle <nick@ntindle.com>

@collijk

* Feature/tighten up ci pipeline (#3700) * Fix docker volume mounts (#3710) Co-authored-by: Reinier van der Leer <github@pwuts.nl> Co-authored-by: Nicholas Tindle <nick@ntindle.com> * Feature/enable intuitive logs for community challenge step 1 (#3695) * Feature/enable intuitive logs summarization (#3697) * Move task_complete command out of prompt (#3663) * feat: move task_complete command out of prompt * fix: formatting fixes * Add the shutdown command to the test agents * tests: update test vcrs --------- Co-authored-by: James Collins <collijk@uw.edu> * Allow users to Disable Commands via the .env (#3667) * Document Disabling command categories (#3669) * feat: move task_complete command out of prompt * fix: formatting fixes * feat: add command disabling * docs: document how to disable command categories * Enable denylist handling for plugins (#3688) Co-authored-by: Luke Kyohere <lkyohere@mfsafrica.com> Co-authored-by: Nicholas Tindle <nick@ntindle.com> * Fix call to `plugin.post_planning` (#3414) Co-authored-by: Nicholas Tindle <nick@ntindle.com> * create information retrieval challenge a (#3770) Co-authored-by: Richard Beales <rich@richbeales.net> * fix typos (#3798) * Update run.bat (#3783) Co-authored-by: Richard Beales <rich@richbeales.net> * Update run.sh (#3752) Co-authored-by: Richard Beales <rich@richbeales.net> * ADD: Bash block in the contributing markdown (#3701) Co-authored-by: Richard Beales <rich@richbeales.net> * BUGFIX: Selenium Driver object reference was included in the browsing results for some reason (#3642) * * there is really no need to return the reference to the Selenium driver along with the text summary and list of links. * * removing unused second return value from browse_website() * * updated cassette * * updated YAML cassette for test_browse_website * * after requirements reinstall, another update YAML cassette for test_browse_website * * another update YAML cassette for test_browse_website, only as a placholder commit to trigger re-testing due to some docker TCP timeout issue * * another update YAML cassette for test_browse_website --------- Co-authored-by: batyu <batyu@localhost> * Update CONTRIBUTING.md * Self feedback Improvement (#3680) * Improved `Self-Feedback` * minor tweak * Test: Updated `test_get_self_feedback.py` * community challenges in the wiki (#3764) * Update README.md * Update PULL_REQUEST_TEMPLATE.md Added link to wiki Contributing page * Add link to wiki Contributing page * fix * Add link to wiki page on Contributing * Implement Logging of User Input in logs/Debug Folder (#3867) * Adds USER_INPUT_FILE_NAME * Update agent.py * Update agent.py Log only if console_input is not the authorise_key * Reformatting * add information retrieval challenge to the wiki (#3876) * add code owners policy (#3981) * add code owners * added @ to codeowners * switched to team ownership * Memory Challenge C (#3908) * Memory Challenge C * Working cassettes * Doc fixes * Linting and doc fix * Updated cassette * One more cassette try --------- Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> * memory challenge c inconsistent (#3985) * Improve & fix memory challenge docs. (#3989) Co-authored-by: Kaan Osmanagaoglu <kaano@questps.com.au> * Feature/centralize prompt (#3990) Co-authored-by: xiao.hu <454292663@qq.com> * Use correct reference to prompt_generator in autogpt/llm/chat.py (#4011) * fix typos (#3998) Co-authored-by: Minfeng Lu <minfenglu@Minfengs-MacBook-Pro.local> Co-authored-by: Richard Beales <rich@richbeales.net> * fix typo in the getting started docs (#3997) Co-authored-by: Richard Beales <rich@richbeales.net> * Fix path to workspace directory in setup guide (#3927) Co-authored-by: Nicholas Tindle <nick@ntindle.com> * document that docker-compose 1.29.0 is minimally required (#3963) Co-authored-by: Nicholas Tindle <nick@ntindle.com> * Integrate pytest-xdist Plugin for Parallel and Concurrent Testing (#3870) * Adds pytest-parallel dependencies * Implement pytest-parallel for faster tests * Uses pytest-xdist * Auto number of workers processes * Update ci.yml --------- Co-authored-by: Nicholas Tindle <nick@ntindle.com> * explain temperature setting in env file (#4140) Co-authored-by: Richard Beales <rich@richbeales.net> * Catch JSON error in summary_memory.py (#3996) Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Update duckduckgo dependency - min should be 2.9.5 (#4142) Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Update Dockerfile - add missing scripts and plugins directories. (#3706) Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Updated memory setup links (#3829) Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Parse package versions so upgrades can be forced (#4149) * parse package versions so upgrades can be forced * better version from @collijk * fix typo in autopgt/agent/agent.py (#3747) Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> Co-authored-by: Richard Beales <rich@richbeales.net> Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Fix `milvus_memory_test.py` mock `Config` (#3424) Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Implemented showing the number of preauthorised commands left. #1035 (#3322) Co-authored-by: mayubi <marwand@ayubi-it.de> Co-authored-by: Nicholas Tindle <nick@ntindle.com> Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Challenge: Kubernetes and documentation (#4121) * challenge_kubes_and_readme * docs * testing * black and isort * revision * lint * comments * blackisort * docs * docs * deleting_cassette * suggestions * misspelling_errors --------- Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> * Make sdwebui tests pass (when SD is running) (#3721) Co-authored-by: Nicholas Tindle <nick@ntindle.com> * Add Edge browser support using EdgeChromiumDriverManager (#3058) Co-authored-by: Nicholas Tindle <nick@ntindle.com> Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> * Added --install-plugin-deps to Docker (#4151) Co-authored-by: Nicholas Tindle <nick@ntindle.com> * Feature/basic proxy (#4164) * basic proxy (#54) * basic proxy (#55) * basic proxy * basic proxy * basic proxy * basic proxy * add back double quotes * add more specific files * write file * basic proxy * Put back double quotes * test new CI (#4168) * test new CI * test new CI * remove double quotes * Feature/test new ci pipeline 2 (#4169) * test new CI * remove double quotes * make it a variable * make it a variable * Test New CI Pipeline (#4170) * introduce dummy prompt change * introduce dummy prompt change * empty commit * empty commit * empty commit * push to origin repo * add s to quote * Feature/fix rate limiting issue Step 1 (#4173) * temporarilly remove 3.11 * add back 3.11 (#4185) * Revert "Put back 3.11 until it's removed as a requirement" (#4191) --------- Co-authored-by: Reinier van der Leer <github@pwuts.nl> Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> Co-authored-by: Peter Petermann <ppetermann80@googlemail.com> Co-authored-by: Nicholas Tindle <nick@ntindle.com> Co-authored-by: James Collins <collijk@uw.edu> Co-authored-by: Luke K <2609441+pr-0f3t@users.noreply.github.com> Co-authored-by: Luke Kyohere <lkyohere@mfsafrica.com> Co-authored-by: Robin Richtsfeld <robin.richtsfeld@gmail.com> Co-authored-by: RainRat <rainrat78@yahoo.ca> Co-authored-by: itsmarble <130370814+itsmarble@users.noreply.github.com> Co-authored-by: Ambuj Pawar <pawar.ambuj@gmail.com> Co-authored-by: bszollosinagy <4211175+bszollosinagy@users.noreply.github.com> Co-authored-by: batyu <batyu@localhost> Co-authored-by: Pi <sunfish7@gmail.com> Co-authored-by: AbTrax <45964236+AbTrax@users.noreply.github.com> Co-authored-by: Andres Caicedo <73312784+AndresCdo@users.noreply.github.com> Co-authored-by: Douglas Schonholtz <15002691+dschonholtz@users.noreply.github.com> Co-authored-by: Kaan <kaanixir@gmail.com> Co-authored-by: Kaan Osmanagaoglu <kaano@questps.com.au> Co-authored-by: xiao.hu <454292663@qq.com> Co-authored-by: Tomasz Kasperczyk <tomaszikasperczyk@gmail.com> Co-authored-by: minfeng-ai <42948406+minfenglu@users.noreply.github.com> Co-authored-by: Minfeng Lu <minfenglu@Minfengs-MacBook-Pro.local> Co-authored-by: Shlomi <81581678+jit-shlomi@users.noreply.github.com> Co-authored-by: Itai Steinherz <itaisteinherz@gmail.com> Co-authored-by: Boostrix <119627414+Boostrix@users.noreply.github.com> Co-authored-by: Kristian Jackson <kristian.jackson@gmail.com> Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> Co-authored-by: Eduardo Salinas <edus@microsoft.com> Co-authored-by: prom3theu5 <dave@simcube.co.uk> Co-authored-by: dominic-ks <contact@bedevious.co.uk> Co-authored-by: andrey13771 <51243350+andrey13771@users.noreply.github.com> Co-authored-by: Marwand Ayubi <98717667+xhypeDE@users.noreply.github.com> Co-authored-by: mayubi <marwand@ayubi-it.de> Co-authored-by: Media <12145726+rihp@users.noreply.github.com> Co-authored-by: Cenny <cwenner@gmail.com> Co-authored-by: Abdelkarim Habouch <37211852+karimhabush@users.noreply.github.com>

Fix call to plugin.post_planning

17aecf1

github-actions bot added the size/s label Apr 27, 2023

Merge branch 'master' into patch-5

a0a95c3

vercel bot temporarily deployed to Preview April 29, 2023 06:01 Inactive

ntindle self-assigned this Apr 29, 2023

ntindle added the function: plugins label Apr 29, 2023

ntindle approved these changes May 1, 2023

View reviewed changes

Merge branch 'master' into patch-5

a2ec942

vercel bot temporarily deployed to Preview May 1, 2023 23:43 Inactive

ntindle approved these changes May 4, 2023

View reviewed changes

Merge branch 'master' into patch-5

c899ac2

ntindle added this to the v0.3.1 Release milestone May 4, 2023

vercel bot temporarily deployed to Preview May 4, 2023 02:40 Inactive

ntindle merged commit cb97f5c into Significant-Gravitas:master May 4, 2023

ddannyc pushed a commit to ddannyc/Auto-GPT that referenced this pull request May 5, 2023

Fix call to plugin.post_planning (Significant-Gravitas#3414)

2a30018

Co-authored-by: Nicholas Tindle <nick@ntindle.com>

Androbin deleted the patch-5 branch May 5, 2023 03:47

dschonholtz pushed a commit to dschonholtz/Auto-GPT that referenced this pull request May 6, 2023

Fix call to plugin.post_planning (Significant-Gravitas#3414)

e7b8ed3

Co-authored-by: Nicholas Tindle <nick@ntindle.com>

RealHossie pushed a commit to RealHossie/Auto-GPT-Chinese that referenced this pull request May 6, 2023

Fix call to plugin.post_planning (Significant-Gravitas#3414)

12cc1b9

Co-authored-by: Nicholas Tindle <nick@ntindle.com>

jaimevalero pushed a commit to jaimevalero/Auto-GPT that referenced this pull request May 14, 2023

Fix call to plugin.post_planning (Significant-Gravitas#3414)

b0bd936

Co-authored-by: Nicholas Tindle <nick@ntindle.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix call to `plugin.post_planning` #3414

Fix call to `plugin.post_planning` #3414

Androbin commented Apr 27, 2023 •

edited

Loading

vercel bot commented Apr 27, 2023 •

edited

Loading

codecov bot commented Apr 27, 2023 •

edited

Loading

ntindle commented Apr 29, 2023

bobisme commented Apr 29, 2023

Fix call to plugin.post_planning #3414

Fix call to plugin.post_planning #3414

Conversation

Androbin commented Apr 27, 2023 • edited Loading

Background

Signature

Changes

Before

After

Documentation

Test Plan

PR Quality Checklist

vercel bot commented Apr 27, 2023 • edited Loading

codecov bot commented Apr 27, 2023 • edited Loading

Codecov Report

ntindle commented Apr 29, 2023

bobisme commented Apr 29, 2023

Fix call to `plugin.post_planning` #3414

Fix call to `plugin.post_planning` #3414

Androbin commented Apr 27, 2023 •

edited

Loading

vercel bot commented Apr 27, 2023 •

edited

Loading

codecov bot commented Apr 27, 2023 •

edited

Loading