devops cleanups #49
Closed
devops cleanups #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astelmach01
commented
Apr 2, 2023
•
astelmach01
commented
- Added pip-tools functionality. Instead of adding to requirements.txt, simply add the library to requirements.in and run pip-compile after installing pip-tools
- Cleaned up dockerfile to install requirements first for a quick optimization
- Changed docker image from 3.8 -> 3.10
- Added a proper gitignore
|
Also related #137 |
nponeccop
suggested changes
Apr 9, 2023
| @@ -1,8 +1,12 @@ | |||
| FROM python:3.11 | |||
| FROM python:3.10-slim | |||
There was a problem hiding this comment.
Python bump is and using a slim image are separate design decisions. Use 2 separate PRs for this single line as it's easier to approve and merge them.
|
|
||
| RUN pip install -r requirements.txt | ||
| COPY requirements.txt /app/requirements.txt |
There was a problem hiding this comment.
This change is done elsewhere (in different PRs) already. Search for the PR number(s) and add a comment. Remove from this PR.
There was a problem hiding this comment.
It's a good idea to generate requirements.txt for a more precice dependency pindown. Explain the advantages and submit only this improvement as a separate PR.
| @@ -18,7 +18,7 @@ def execute_python_file(file): | |||
| try: | |||
| client = docker.from_env() | |||
|
|
|||
| # You can replace 'python:3.8' with the desired Python image/version | |||
There was a problem hiding this comment.
This typo should be a separate PR independent of all the above.
tgonzales
pushed a commit
to tgonzales/Auto-GPT
that referenced
this pull request
Apr 19, 2023
🔨 Improve local development setup to be SQLite compatible
Say383
pushed a commit
to Say383/Auto-GPT
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.