Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for #803 - Debug mode #888

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

chozzz
Copy link
Contributor

@chozzz chozzz commented Apr 12, 2023

Background

Changes

  • Fix debug mode not debug #803
    • Brings back debug mode
    • Replaces all callees from cfg.debug to cfg.debug_mode that was updated on 5b2d601
    • Remove unnecessary config instance at main.py

Test Plan

I added a test placeholder for the unit test of local cache. I am wondering if we can have the git workflow hook to run basic unit test? @Torantulino

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thouroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@chozzz chozzz mentioned this pull request Apr 12, 2023
5 tasks
@chozzz chozzz changed the title Bugfix Bugfix for #803 and #823 Apr 12, 2023
@GiveMeDaTaco
Copy link

These changes are definitely needed. Thanks, man.

@KixPanganiban
Copy link

+1 to this! Was thinking of sending in a similar PR, but you already did it first and better. Thanks @chozzz

scripts/memory/local.py Outdated Show resolved Hide resolved
tests/local_cache_test.py Outdated Show resolved Hide resolved
@chozzz chozzz force-pushed the bugfix branch 2 times, most recently from 472b725 to 480cfd0 Compare April 12, 2023 05:55
@chozzz chozzz requested a review from nponeccop April 12, 2023 05:56
@chozzz chozzz changed the title Bugfix for #803 and #823 Bugfix for #803 Apr 12, 2023
@chozzz chozzz changed the title Bugfix for #803 Bugfix for #803 - Debug mode Apr 12, 2023
scripts/main.py Outdated Show resolved Hide resolved
scripts/main.py Outdated Show resolved Hide resolved
- Brings back debug mode
- Replaces all calls from cfg.debug to cfg.debug_mode that was updated on 5b2d601
- Remove unnecessary config instance at main.py
@nponeccop
Copy link
Contributor

@Torantulino Can we fix the master?

@nponeccop nponeccop mentioned this pull request Apr 12, 2023
1 task
@richbeales richbeales merged commit 3ea57ca into Significant-Gravitas:master Apr 12, 2023
SquareandCompass pushed a commit to SquareandCompass/Auto-GPT that referenced this pull request Oct 21, 2023
* add cost budget; move loc of make_dir

* remove None in return

---------

Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug mode not debug
5 participants