Various Wielding Fixes #1078
Merged
Various Wielding Fixes #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds wielding assets * Modifies meta.json files and adds artist credit * Adds wieldable component to a bunch of weapons * Moves shotgun inhands and wield inhands to their own folders (because its the only way the sprites would work) * Removes the wieldable component from some guns * Adds wielding sprites for wieldable guns that didnt have them * Adds gun wielding bonuses and base innaccuracy to wieldable guns. * Corrects wielded accuracy to be default accuracy instead of perfect * Makes the drozd smg and bulldog shotgun wieldable * Makes nukie c20r wieldable and adds sprites * Adds BaseGunWieldable * Makes all the newly wieldable gun use the base inheritable * Adds accuracy to smgs to resolve inheritance conflict * Makes all wieldable shotguns require wielding to fire because of a bug involving spread innacuracy * Adds wield bonus message on examine
…shot (#27973) Make failing to fire a wield-only gun not delay the next shot
* Make wielding automatically drop the item on your other hand * Fix docs * Remove redundant parameter * Fix not deleting virtuals on fail * Make count freeable hands method * Add popup when dropping item
Unhand me, fiend
github-actions
bot
added
Changes: C#
FoxxoTrystan
requested review from
a team,
FoxxoTrystan,
DEATHB4DEFEAT,
Peptide90,
Pspritechologist and
OldDanceJacket
and removed request for
a team
FoxxoTrystan
added
Priority: 2-High
DEATHB4DEFEAT
approved these changes
Oct 19, 2024
Content.Shared/Inventory/VirtualItem/SharedVirtualItemSystem.cs
Outdated
Show resolved
Hide resolved
Content.Shared/Inventory/VirtualItem/SharedVirtualItemSystem.cs
Outdated
Show resolved
Hide resolved
Peptide90
approved these changes
Oct 19, 2024
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> Signed-off-by: VMSolidus <evilexecutive@gmail.com>
VMSolidus
pushed a commit
to VMSolidus/Einstein-Engines
that referenced
this pull request
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unhand me, fiend
Description
Literally all of Wizden's "Wielding Quality Of Life" improvements.
Fixes #1074
Fixes #1073
Cherry-picks the following PRs:
space-wizards/space-station-14#26970
space-wizards/space-station-14#27973
space-wizards/space-station-14#27975
space-wizards/space-station-14#28438
space-wizards/space-station-14#27975
space-wizards/space-station-14#28002
space-wizards/space-station-14#28161
Changelog
🆑