Changing hands unwields item #28161
Merged
Changing hands unwields item #28161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wouldn't it also be useful to wield the thing automatically if you change hands to it with a free hand? although someone else suggested it would be more ideal for wieldable things to be treated as wielded automatically if you ever have a free hand rather than it taking up an action... eh, probably out of scope |
|
yeah i think this is fine. if its cbt then just revert |
1 task
rbertoche
pushed a commit
to rbertoche/space-station-14
that referenced
this pull request
Jun 24, 2024
Unhand me, fiend
VMSolidus
added a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Oct 20, 2024
Unhand me, fiend # Description Literally all of Wizden's "Wielding Quality Of Life" improvements. Fixes #1074 Fixes #1073 Cherry-picks the following PRs: space-wizards/space-station-14#26970 space-wizards/space-station-14#27973 space-wizards/space-station-14#27975 space-wizards/space-station-14#28438 space-wizards/space-station-14#27975 space-wizards/space-station-14#28002 space-wizards/space-station-14#28161 # Changelog :cl: - fix: Ported literally all of Wizden's Wielding Quality Of Life improvements. --------- Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: RiceMar1244 <138547931+RiceMar1244@users.noreply.github.com> Co-authored-by: DrSmugleaf <10968691+DrSmugleaf@users.noreply.github.com> Co-authored-by: WarMechanic <69510347+WarMechanic@users.noreply.github.com> Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com> Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Spatison
pushed a commit
to WWhiteDreamProject/wwdpublic
that referenced
this pull request
Nov 19, 2024
Unhand me, fiend # Description Literally all of Wizden's "Wielding Quality Of Life" improvements. Fixes #1074 Fixes #1073 Cherry-picks the following PRs: space-wizards/space-station-14#26970 space-wizards/space-station-14#27973 space-wizards/space-station-14#27975 space-wizards/space-station-14#28438 space-wizards/space-station-14#27975 space-wizards/space-station-14#28002 space-wizards/space-station-14#28161 # Changelog :cl: - fix: Ported literally all of Wizden's Wielding Quality Of Life improvements. --------- Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: RiceMar1244 <138547931+RiceMar1244@users.noreply.github.com> Co-authored-by: DrSmugleaf <10968691+DrSmugleaf@users.noreply.github.com> Co-authored-by: WarMechanic <69510347+WarMechanic@users.noreply.github.com> Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com> Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> (cherry picked from commit 0383090d67bfdf777134647aed48060d424db416)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Guns are being changed to no longer unwield when Use Item In Hand is pressed #28002. The next best way to unwield an item is to switch to the other hand and press Drop. This change just makes it so the item unwields when you change hands, no need to also press Drop. I can't think of a plausible reason anyone would change hands while wielding an item except to use the second hand for something else
Why / Balance
QOL, saves one pointless keypress, hopefully more intuitive to those who did not already know you can "drop" the second hand to unwield
Media
Changelog
🆑 Errant