Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "App Route" to "Page" #1159

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Rename "App Route" to "Page" #1159

merged 2 commits into from
Sep 21, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Sep 16, 2022

Description / Motivation

Rename AppRoute -> Page:

  • graphql query
  • introspection result
  • definition files

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team September 18, 2022 22:28
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor suggestion, otherwise looks good!

@illiakovalenko illiakovalenko merged commit e1d1a02 into dev Sep 21, 2022
@illiakovalenko illiakovalenko deleted the feature/538063 branch September 21, 2022 07:30
illiakovalenko added a commit that referenced this pull request Nov 28, 2022
ambrauer pushed a commit that referenced this pull request Nov 29, 2022
ambrauer added a commit that referenced this pull request Dec 6, 2022
This reverts commit e1d1a02.

(cherry picked from commit a6df388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants