Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Page template back to AppRoute #1249

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Rename Page template back to AppRoute #1249

merged 1 commit into from
Nov 29, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Nov 28, 2022

This reverts commit e1d1a02.

Description / Motivation

The new Page template name conflicts with SXA Page.
Typed GraphQL doesn't support duplicate type names, so we have to rename Page back to AppRoute to resolve the conflict.

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team November 28, 2022 09:21
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit a6df388 into dev Nov 29, 2022
@ambrauer ambrauer deleted the feature/557314 branch November 29, 2022 20:10
ambrauer added a commit that referenced this pull request Dec 6, 2022
This reverts commit e1d1a02.

(cherry picked from commit a6df388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants