Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#582982: [nextjs-sxa] changed type of text for Promo Component #1504

Merged
merged 2 commits into from
Jun 2, 2023
Merged

#582982: [nextjs-sxa] changed type of text for Promo Component #1504

merged 2 commits into from
Jun 2, 2023

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented May 31, 2023 •
edited
Loading

Description / Motivation

Fixed type of Text2 for Promo Component in WithText variant

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi changed the title #582982: changed type of text for Promo Component #582982: [nextjs-sxa] changed type of text for Promo Component Jun 2, 2023
@illiakovalenko illiakovalenko merged commit 1d1af9f into dev Jun 2, 2023
@illiakovalenko illiakovalenko deleted the bugfix/582982-fixed-promo-component branch June 2, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-ruslanmatkovskyi @illiakovalenko