Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#582982: [nextjs-sxa] changed type of text for Promo Component #1504

Merged
merged 2 commits into from
Jun 2, 2023
Merged

#582982: [nextjs-sxa] changed type of text for Promo Component #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5457767
#582982: changed type of text for Promo Component
sc-ruslanmatkovskyi May 31, 2023
441d151
#582982: changed CHANGELOG
sc-ruslanmatkovskyi May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ Our versioning strategy is as follows:
* Fix installed sitecore-jss-* dependency version ([#1478](https://github.com/Sitecore/jss/pull/1478))
* [node-headless-ssr-experience-edge] Add helper comment for rootItemId ([#1491](https://github.com/Sitecore/jss/pull/1491))
* `[templates/nextjs-sxa]` Add condition DISABLE_SSG_FETCH for 404/500 pages to enable full ISR (Incremental Static Regeneration) flow ([#1496](https://github.com/Sitecore/jss/pull/1496))
* `[templates/nextjs-sxa]` Fix type(from Text to RichText) of editing text in value Text2 for Promo Component in WithText variant ([#1504](https://github.com/Sitecore/jss/pull/1504)).

## 21.1.6

Expand Down
5 changes: 2 additions & 3 deletions packages/create-sitecore-jss/src/templates/nextjs-sxa/src/components/Promo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
ImageField,
Field,
LinkField,
Text,
} from '@sitecore-jss/sitecore-jss-nextjs';

interface Fields {
Expand Down Expand Up @@ -68,11 +67,11 @@ export const WithText = (props: PromoProps): JSX.Element => {
<div className="promo-text">
<div>
<div className="field-promotext">
<Text className="promo-text" field={props.fields.PromoText} />
<JssRichText className="promo-text" field={props.fields.PromoText} />
</div>
</div>
<div className="field-promotext">
<Text className="promo-text" field={props.fields.PromoText2} />
<JssRichText className="promo-text" field={props.fields.PromoText2} />
</div>
</div>
</div>
Expand Down