Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Styleguide-Layout-Reuse breaks EE #937

Merged
merged 4 commits into from
Mar 3, 2022
Merged

[Vue] Styleguide-Layout-Reuse breaks EE #937

merged 4 commits into from
Mar 3, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Mar 2, 2022 •
edited
Loading

Description / Motivation

Provide props to check that component is raw

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@vercel
Copy link

vercel bot commented Mar 2, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/GJ1Y62sa8jpcPg1ZF1GJwvTAG2jP
✅ Preview: Failed

[Deployment for 8552f67 failed]

@illiakovalenko illiakovalenko requested a review from a team March 2, 2022 14:47
ambrauer
ambrauer approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a super minor comment, otherwise looks good to me

packages/sitecore-jss-vue/src/components/PlaceholderCommon.ts Outdated Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit 2d9d346 into dev Mar 3, 2022
@illiakovalenko illiakovalenko deleted the bugfix/514959 branch March 3, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer