Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Styleguide-Layout-Reuse breaks EE #937

Merged
merged 4 commits into from
Mar 3, 2022
Merged

[Vue] Styleguide-Layout-Reuse breaks EE #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fbd302
[Vue] Styleguide-Layout-Reuse breaks EE
illiakovalenko Mar 2, 2022
1857f64
Use `data` attribute
illiakovalenko Mar 2, 2022
675da01
Update CHANGELOG
illiakovalenko Mar 2, 2022
8552f67
Use `elem` instead of `data`
illiakovalenko Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ This project does NOT adhere to [Semantic Versioning](https://semver.org/spec/v2
* Console error when /graphql requested in EE, localhost or horizon ([#803](https://github.com/Sitecore/jss/pull/803))

`[vue]`
* Styleguide-Layout-Reuse breaks EE ([#938](https://github.com/Sitecore/jss/pull/938))
* The page is redirected to the home page of the website after clicking the "Change associated content" button in the Experience Editor ([#907](https://github.com/Sitecore/jss/pull/907))
* Cannot add a new rendering to the newly created ([#903](https://github.com/Sitecore/jss/pull/903))
* `[Horizon]` Cannot add a new rendering or highlight existing ([#895](https://github.com/Sitecore/jss/pull/895))
Expand Down
4 changes: 2 additions & 2 deletions packages/sitecore-jss-vue/src/components/PlaceholderCommon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export function convertVNodesToDynamicComponents(vnodes: VNode[]) {
},
} as JssDynamicComponent;

if (vnode.type === 'code' && vnode.props.type === 'text/sitecore') {
if (vnode.props.elem?.name === 'code' && vnode.props.elem?.type === 'text/sitecore') {
component.isxEditorComponent = true;
}
return component;
Expand Down Expand Up @@ -234,7 +234,7 @@ function createRawElement(elem: any) {
},
};

return h(component);
return h(component, { elem });
}

/**
Expand Down
Loading