Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: More info in tracker table and IMU visualizer #450

Merged
merged 12 commits into from
Jan 18, 2023

Conversation

0forks
Copy link
Contributor

@0forks 0forks commented Jan 4, 2023

Requires:


  • Adds an IMU visualizer;

    image

  • Adds a widget with toggles to the side:

    Show image
    image

  • Extends tracker table with TPS, temperature and linear acceleration columns, less useful data columns are hidden behind a toggle;

  • Temperature column is automatically hidden if there is no temperature data for any device;

  • Adds a developer mode widget with toggles to set high contrast for better accessibility, increasing table update rate, basic filtering and sorting;

  • Fixes a case when ping = 0 displays as an empty cell in the tracker table (wrangler, owotrack, anything local);

  • Improves reaction to shaking when highlighting trackers, since the server can now send linear acceleration in addition to rotation data;

  • Adds a warning highlight/icon for unassigned trackers, since reference/identity-adjusted rotations (after reset) only apply to assigned trackers:

    image

owo

@0forks 0forks marked this pull request as draft January 4, 2023 11:06
@ButterscotchV ButterscotchV added Area: Application Protocol Related to communication with apps like the GUI, overlay, games Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature Priority: Normal The default priority Status: Blocked by other issue Progress cannot be made until linked issue is resolved labels Jan 4, 2023
@Eirenliel
Copy link
Member

Adds a developer mode widget with toggles to set high contrast for better accessibility

is this for developer mode only? would be useful for everyone tbh

@0forks
Copy link
Contributor Author

0forks commented Jan 5, 2023

Adds a developer mode widget with toggles to set high contrast for better accessibility

is this for developer mode only? would be useful for everyone tbh

For now the high contrast toggle affects only the numbers in the tracker table, which is accessible only with developer mode enabled. I had personally found the numbers hard to look at for extended periods of time with the text color set as "secondary", so it's an optional toggle. It's easy to remove the toggle and make it a default, but I'm not sure if most people would find it preferable.

Here's before and after comparison:
image

Adding high contrast mode globally is somewhat out of scope for this PR and I think general accessibility should be discussed separately, since it requires tweaking the whole UI and design guidelines.

@0forks 0forks marked this pull request as ready for review January 16, 2023 14:32
@Erimelowo Erimelowo removed the Status: Blocked by other issue Progress cannot be made until linked issue is resolved label Jan 17, 2023
@TheButlah
Copy link
Contributor

TheButlah commented Jan 18, 2023

needs rebase or merge

owo

@Eirenliel Eirenliel merged commit 564be61 into SlimeVR:main Jan 18, 2023
@0forks 0forks deleted the pr-gui-devgui branch January 18, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Application Protocol Related to communication with apps like the GUI, overlay, games Area: GUI Related to the GUI Priority: Normal The default priority Type: Enhancement Adds or improves a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants