Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Send accel and ref-adjusted rotations #449

Merged
merged 3 commits into from
Jan 16, 2023
Merged

server: Send accel and ref-adjusted rotations #449

merged 3 commits into from
Jan 16, 2023

Conversation

0forks
Copy link
Contributor

@0forks 0forks commented Jan 4, 2023 •
edited
Loading

@0forks 0forks mentioned this pull request Jan 4, 2023
Merged
2 tasks
@0forks 0forks marked this pull request as draft January 4, 2023 11:06
@ButterscotchV ButterscotchV added Type: Feature Request Area: Application Protocol Related to communication with apps like the GUI, overlay, games Priority: High Important feature or blocks something important Priority: Normal The default priority and removed Priority: High Important feature or blocks something important labels Jan 4, 2023
@0forks 0forks marked this pull request as ready for review January 5, 2023 07:57
ButterscotchV
ButterscotchV approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, the "reset" stuff in IMUTracker.java is a bit confusing to read, so I'd like it to be tested to be sure it still functions the same (and maybe others can check the code better)

Eirenliel
Eirenliel approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@Eirenliel Eirenliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes rotation code, needs to be beta-tested. @Louka3000

Eirenliel
Eirenliel requested changes Jan 8, 2023
View reviewed changes
Copy link
Member

@Eirenliel Eirenliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes rotation code, needs to be beta-tested. @Louka3000

Also it doesn't build @0forks.

Eirenliel
Eirenliel approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@Eirenliel Eirenliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing

@Erimelowo
Copy link
Member

Needs testing

Works fine on my side, and believe 0. made a lot of people on Discord test it as well (especially people using BMIs in the BMI thread)

@0forks
Copy link
Contributor Author

0forks commented Jan 9, 2023 •
edited
Loading

  1. made a lot of people on Discord test it as well (especially people using BMIs in the BMI thread)

That was before server code changes, old code was calculating all that in the GUI and didn't touch IMUTracker. There were a lot of changes since 0.4.0.

@Erimelowo
Copy link
Member

Anyway, I just tested in VR and both manual mounting and using mounting reset work just fine.

@Eirenliel Eirenliel merged commit 50eef6e into SlimeVR:main Jan 16, 2023
@0forks 0forks deleted the pr-server-refadj branch January 18, 2023 20:51
@TheButlah TheButlah added Type: Enhancement Adds or improves a feature and removed Type: Feature Request labels Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erimelowo Erimelowo Erimelowo approved these changes

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@Eirenliel Eirenliel Eirenliel approved these changes

Assignees
No one assigned
Labels
Area: Application Protocol Related to communication with apps like the GUI, overlay, games Priority: Normal The default priority Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0forks @Erimelowo @Eirenliel @ButterscotchV @TheButlah