Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "wifi" to "Wi-Fi" and "SSID" to "Wi-Fi" name #468

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Rename "wifi" to "Wi-Fi" and "SSID" to "Wi-Fi" name #468

merged 2 commits into from
Jan 16, 2023

Conversation

Erimelowo
Copy link
Member

@Erimelowo Erimelowo requested a review from ImUrX January 9, 2023 16:51
ImUrX
ImUrX requested changes Jan 9, 2023
View reviewed changes
gui/public/i18n/en/translation.ftl Outdated Show resolved Hide resolved
@Erimelowo Erimelowo requested a review from ImUrX January 9, 2023 23:09
ButterscotchV
ButterscotchV approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add SSID in brackets, but if that makes it too long or unecessary, then it's fine without too

@ButterscotchV ButterscotchV added Type: Enhancement Adds or improves a feature Area: Translation Improvements or additions to translations labels Jan 10, 2023
@Eirenliel Eirenliel merged commit a008958 into main Jan 16, 2023
@Eirenliel Eirenliel deleted the wifi-translation branch January 16, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@ImUrX ImUrX ImUrX approved these changes

Assignees
No one assigned
Labels
Area: Translation Improvements or additions to translations Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Erimelowo @ImUrX @ButterscotchV @Eirenliel