fix: websocket fail to bind to address due to time_wait #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcozzxx810
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
|
Great, glad someone tackled this :) |
TheButlah
approved these changes
Feb 5, 2023
ButterscotchV
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
It seems implied that this option can forcibly bind to an occupied socket. I'm unsure of the ideal behaviour for the websocket, but this should in theory resolve the linked issue.
See the documentation at https://learn.microsoft.com/en-us/windows/win32/winsock/using-so-reuseaddr-and-so-exclusiveaddruse#using-so_reuseaddr
Eirenliel
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #515
setReuseAddr(true) is the Setter for soReuseAddr Enable/disable SO_REUSEADDR for the socket
SO_REUSEADDR allows the server to bind to an address which is in a TIME_WAIT state
https://www.javadoc.io/doc/org.java-websocket/Java-WebSocket/1.3.5/org/java_websocket/server/WebSocketServer.html