Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference adjusted rotation data for IMU trackers #77

Merged
merged 6 commits into from
Jan 7, 2023
Merged

Add reference adjusted rotation data for IMU trackers #77

merged 6 commits into from
Jan 7, 2023

Conversation

0forks
Copy link
Contributor

@0forks 0forks commented Nov 27, 2022

No description provided.

TheButlah
TheButlah requested changes Nov 27, 2022
View reviewed changes
Copy link
Collaborator

@TheButlah TheButlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Renames look good to me, had some confusion on the reference adjusted tracker stuff though.

Can you explain a bit about what the purpose of that is? Also, who determines that info and does it ever change?

schema/data_feed/tracker.fbs Outdated Show resolved Hide resolved
schema/data_feed/tracker.fbs Outdated Show resolved Hide resolved
@0forks
Copy link
Contributor Author

0forks commented Nov 28, 2022

Noted, will try to make everything more clear and possibly optimize sending this data, turning into a draft for now.
These quaternions are required to calculate orientation and its different intermediate steps after doing a reset to visualize it in the GUI (upcoming developer mode improvements).

@0forks 0forks marked this pull request as draft November 28, 2022 03:42
@0forks 0forks changed the title Add reference adjustment parameters for IMU trackers Add reference adjusted rotation data for IMU trackers Jan 4, 2023
@0forks
Copy link
Contributor Author

0forks commented Jan 4, 2023

Reworked the code and added proper docs, now the extra rotation data is opt-in.

@0forks 0forks mentioned this pull request Jan 4, 2023
Merged
2 tasks
@0forks 0forks marked this pull request as ready for review January 4, 2023 11:07
@0forks 0forks requested a review from TheButlah January 4, 2023 21:22
@0forks 0forks requested a review from TheButlah January 5, 2023 08:00
Erimelowo
Erimelowo previously approved these changes Jan 5, 2023
View reviewed changes
TheButlah
TheButlah requested changes Jan 5, 2023
View reviewed changes
schema/data_feed/tracker.fbs Show resolved Hide resolved
schema/data_feed/tracker.fbs Show resolved Hide resolved
schema/data_feed/tracker.fbs Outdated Show resolved Hide resolved
@TheButlah TheButlah merged commit 46123c8 into SlimeVR:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erimelowo Erimelowo Erimelowo left review comments

@TheButlah TheButlah TheButlah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0forks @TheButlah @Erimelowo