Skip to content

Commit

Permalink
Minor template/stale message improvements (devicons#1381)
Browse files Browse the repository at this point in the history
* Minor template/stale message improvements

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen < <Snailedlt@users.noreply.github.com>>

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
  • Loading branch information
Panquesito7 and Snailedlt committed Oct 15, 2022
1 parent 96b68e5 commit 5509bf6
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 17 deletions.
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Bug Report
description: Report a bug/issue that you found in the SVGs, CSS files, etc.
title: '[BUG] <bug name>'
description: Report a bug/issue that you found in the SVGs, CSS files, or any other bug you encounter.
title: '[BUG]: <bug name>'
labels: [bug]
body:
- type: markdown
Expand All @@ -18,7 +18,7 @@ body:
id: description
attributes:
label: Bug description
description: Short description of the bug that you found. Provide images/code if applicable.
description: Short description of the bug. Provide images/code if applicable.
validations:
required: true

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Feature Request
description: Requesting a new feature or changes to an existing feature
title: '[FEATURE REQUEST] <feature name>'
title: '[FEATURE REQUEST]: <feature name>'
labels: [enhancement]
body:
- type: markdown
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/icon_request.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Icon Request
description: Requesting a new icon or changes to an existing icon
description: Request a new icon, or changes to an existing icon
title: '[ICON REQUEST]: <icon name>'
labels: ["request:icon"]
body:
Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/other.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Other
description: Use this for any other issues. Do not create blank issues
title: "[OTHER] <description>"
description: Use this for any other issues. Please do NOT create blank issues
title: "[OTHER]: <description>"
labels: ["awaiting triage"]
body:
- type: markdown
Expand Down
3 changes: 2 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE/new_feature.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
- [ ] PR does not match another non-stale PR currently opened

## Features
<!-- List your features here and the benefits they bring. Include images/codes as appropriate -->
<!-- List your features here and the benefits they bring. Include images/codes if appropriate -->

**This PR closes NONE**
<!-- List issues that this PR would close above. Ex: This PR closes #1, #2, #3. -->
<!-- If your pull request does not fix any issue, it's best to make an issue OR remove this section, depending on your changes. -->

## Notes
<!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). -->
13 changes: 8 additions & 5 deletions .github/drafts/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,16 @@ jobs:
- uses: actions/stale@main
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-pr-message: 'Hello there,
we noticed that this PR has been inactive for a while now. If there are any changes which are suitable for our repository,
we would love to have it. It would be great if you can continue with this PR, but if you cannot, we might fork your changes and merge the changes ourselves.
stale-pr-message: "Hello there,
we have noticed that this PR has been inactive for a while now. If there are any changes which are suitable for our repository,
we would love to have it. It would be great if you can continue with this PR, but if you can't, we might fork your changes and merge them ourselves.
Since GitHub tracks contributions by commits, you will still be credited.
Since GitHub tracks contributions by commits, you'll still be credited.
Let us know what you think about this. :slight_smile:
Let us know what you think 😃'
Feel free to [join our Discord server](https://discord.gg/hScy8KWACQ) for support, hangouts, and more
Thank you and have a nice day!"
stale-pr-label: 'stale'
days-before-pr-stale: 30
days-before-pr-close: -1
14 changes: 10 additions & 4 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
### Adding a New Icon?
- Add `?quick_pull=1&template=new_icon.md` to the end of your current URL and press `Enter`
<!--
### Adding a New Feature or fixing a bug?
- Add `?quick_pull=1&template=new_feature.md` to the end of your current URL and press `Enter`.
Adding a New Icon?
- Add `?quick_pull=1&template=new_icon.md` to the end of your current URL and press `Enter`.
Adding a New Feature or fixing a bug?
- Add `?quick_pull=1&template=new_feature.md` to the end of your current URL and press `Enter`.
-->

0 comments on commit 5509bf6

Please sign in to comment.