Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor template/stale message improvements #1381

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Minor template/stale message improvements #1381

merged 3 commits into from
Sep 26, 2022

Conversation

Panquesito7
Copy link
Member

Things added/changed:

  • Minor template/stale message improvements.

Snailedlt
Snailedlt requested changes Sep 24, 2022
View reviewed changes
.github/drafts/stale.yml Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE/new_feature.md Outdated Show resolved Hide resolved
.github/drafts/stale.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/icon_request.yml Outdated Show resolved Hide resolved
@Panquesito7
Apply suggestions from code review
238a3f5 
Co-authored-by: Jørgen Kalsnes Hagen < <Snailedlt@users.noreply.github.com>>
Snailedlt
Snailedlt previously approved these changes Sep 25, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, but I have some more suggestions that you may apply if you agree :)

.github/drafts/stale.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@Panquesito7 @Snailedlt
Apply suggestions from code review
1d1d415 
Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
Snailedlt
Snailedlt approved these changes Sep 25, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

@Panquesito7 Panquesito7 merged commit 132e46d into develop Sep 26, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@Panquesito7 @Snailedlt
Minor template/stale message improvements (devicons#1381)
ca73fbb 
* Minor template/stale message improvements

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen < <Snailedlt@users.noreply.github.com>>

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@Panquesito7 @Snailedlt
Minor template/stale message improvements (devicons#1381)
2a683d1 
* Minor template/stale message improvements

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen < <Snailedlt@users.noreply.github.com>>

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@Panquesito7 @Snailedlt
Minor template/stale message improvements (devicons#1381)
5509bf6 
* Minor template/stale message improvements

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen < <Snailedlt@users.noreply.github.com>>

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
@Panquesito7 Panquesito7 deleted the improve_templates branch May 3, 2023 00:58
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Panquesito7 @Snailedlt