Add email styles support #153

Januszpl · 2017-08-29T13:11:35Z

Add email support

Internal ticket - https://dev.snowdog.pro/issues/32702

…on (without suffix) and for inline version with "-inline" suffix, fix compilation errors with missing/wrong variables name, import in email.scss module email styles only from Magento_Bundle, Magento_Rma, Magento_Sales modules as it's in the magento blank theme

…cks for email clients

styles/email-inline.scss

styles/email.scss

styles/email/_email-base.scss

Igloczek · 2017-09-21T09:59:15Z

styles/email/_email-base.scss

+
+a:visited {
+    color: $link__visited__color !important;
+    text-decoration: $link__visited__text-decoration !important;


If these !important are necessary, should be ignored by sass-lint to not make reports messy.

styles/email/_email-base.scss

styles/email/_email-extend-inline.scss

styles/email/_email-variables.scss

Igloczek · 2017-09-21T10:05:09Z

BTW. Will be better to add some stylelint ignore comments, than disabling checks for the whole files.

… of less files

…e list edited manually if needed

…o2-theme-blank-sass into feature/32702 * 'feature/32702' of https://github.com/SnowdogApps/magento2-theme-blank-sass: #32911: make breakpoints consistent across the sass fiels Accept any version of magento/framework

…disabling rules from email sass files

… lint in _email-base.scss

* develop: Better formatting for version compatibility (#160) Version 0.11.0 Temporaily back to previous dependecy versioning Page is unresponsive after closing login popup in checkout (#156) Checkout sidebar should have a default length of 4

Igloczek

There are not solved conflicts.

Conflicts: Magento_Sales/styles/_email.scss styles/vendor/magento-ui/variables/_email.scss styles/vendor/magento-ui/variables/_messages.scss

…ture more similar to less version, move variables imports to variables partial

…w typography as icons use typography defined variable (font name)

…ed previously in LESS to SASS porting commit (fd0ffcc)

Januszpl · 2018-08-02T09:31:29Z

@Igloczek can you review and check #84

Ig0r-M-magic42 · 2018-08-15T09:10:43Z

styles/vendor/magento-ui/variables/_global.scss

-//  ---------------------------------------------
-
-$indent__base     : 20px !default;
-$indent__xl       : 40px !default;


is this PR abandoned? if not why are global variables removed?

It's not abandoned and this just looks like a bug. This branch was not updated for months, so there might be some old code here.

content of global.scss was moved to variables/_typography where it is in less version and lib.scss was also modified to match closer the look of less version (and easier upgrades). I had some styles issues and it helped me organize things.
It was created like that in ancient times when I guess approach was different to this project - c2c4cee

But I reverted those changes and will make another PR for that part.

Januszpl · 2018-11-26T18:09:03Z

I will try to check this PR again and check/finish all things.

Januszpl · 2018-11-29T03:31:12Z

Already started but it will need to wait to next week when I will come back from a place without access to internet ;)

…ons below typography as icons use typography defined variable (font name)" This reverts commit 61e64ec.

…ke structure more similar to less version, move variables imports to variables partial" This reverts commit ba79372.

… access to variable in email file

Januszpl · 2019-03-03T15:52:23Z

@Igloczek can we merge this and #206 and #207 (tested on my local 2.1, 2.2, 2.3 instances)

resolved

styles/email/_email-base.scss

styles/email/_email-extend-inline.scss

…inline.scss files as in sass version we make manual imports

Janusz Janczy and others added 6 commits August 24, 2017 23:49

#32702: (WIP) add email styles similar to magenta blank theme

c7d8d00

#32702: add missing !default to magento ui variable

f27b71a

#32702: disable linter for some rules relate to email clients

c8502ae

#32702: add email files for ignore list as they often include some ha…

4f27bee

…cks for email clients

Merge branch 'develop' into feature/32702

ffb5a4a

Igloczek suggested changes Sep 21, 2017

View reviewed changes

Igloczek assigned Januszpl Sep 21, 2017

Janusz Janczy added 9 commits October 10, 2017 23:08

#32702: change comments in sass files to reference scss files instead…

286ad8f

… of less files

#32702: remove TODO comment, make module-specific styles for emails b…

408391e

…e list edited manually if needed

#32702: clean email sass files from uncessesary comments

ecf10e6

#32702: clean email sass files from uncessesary comments

3547300

Merge remote-tracking branch 'origin/feature/32702' into feature/32702

4076404

#32702: add disable sass lint rules per line, remove block sass-lint …

141f74e

…disabling rules from email sass files

#32702: add proper disabling linters comments for sass-lint and style…

9483ebc

… lint in _email-base.scss

Merge branch 'develop' into feature/32702

7c954a6

* develop: Better formatting for version compatibility (#160) Version 0.11.0 Temporaily back to previous dependecy versioning Page is unresponsive after closing login popup in checkout (#156) Checkout sidebar should have a default length of 4

Igloczek changed the title ~~Feature/32702~~ Email styles Oct 17, 2017

Igloczek previously requested changes Oct 24, 2017

View reviewed changes

Janusz Janczy and others added 7 commits November 13, 2017 22:51

Merge branch 'develop'

479a3a2

Conflicts: Magento_Sales/styles/_email.scss styles/vendor/magento-ui/variables/_email.scss styles/vendor/magento-ui/variables/_messages.scss

#32702: remove globals and email partials from lib.scss to make struc…

ba79372

…ture more similar to less version, move variables imports to variables partial

#32702: remove global imports from variables partial, move icons belo…

61e64ec

…w typography as icons use typography defined variable (font name)

#32702: revert back email sass files from Magento_Bundle module remov…

58f432f

…ed previously in LESS to SASS porting commit (fd0ffcc)

Merge branch 'develop' into feature/32702

45751f7

Merge branch 'develop' into feature/32702

eaedf9c

Merge branch 'develop' into feature/32702

2547c42

DB-Alex mentioned this pull request Aug 2, 2018

Email styles are missing #84

Closed

Ig0r-M-magic42 reviewed Aug 15, 2018

View reviewed changes

Januszpl and others added 5 commits December 7, 2018 15:14

Merge branch 'develop' into feature/32702

63c19f3

Revert "#32702: remove global imports from variables partial, move ic…

3a76c2f

…ons below typography as icons use typography defined variable (font name)" This reverts commit 61e64ec.

Revert "#32702: remove globals and email partials from lib.scss to ma…

1dffccc

…ke structure more similar to less version, move variables imports to variables partial" This reverts commit ba79372.

#32702: fix error with wrong variable name and reorder imports to get…

19dbcb0

… access to variable in email file

#32702: formatting

43c922a

This was referenced Mar 3, 2019

backport email styles missing fix #206

Merged

Email styles fix backport to v1.1.3 #207

Merged

Januszpl changed the title ~~Email styles~~ Add email styles support Mar 3, 2019

Januszpl requested a review from Igloczek March 4, 2019 14:00

Januszpl requested a review from anqaka April 15, 2019 13:57

Januszpl removed the request for review from Igloczek May 14, 2019 18:22

anqaka reviewed May 15, 2019

View reviewed changes

styles/email/_email-base.scss Show resolved Hide resolved

styles/email/_email-base.scss Show resolved Hide resolved

styles/email/_email-extend-inline.scss Show resolved Hide resolved

anqaka previously approved these changes May 22, 2019

View reviewed changes

Janusz Janczy added 2 commits May 22, 2019 17:59

Merge branch 'develop' into feature/32702

cc73105

#32702: move inline email styles from modules to newly created email-…

a4e6a40

…inline.scss files as in sass version we make manual imports

Januszpl dismissed anqaka’s stale review via b5e27ce May 22, 2019 22:13

#32702: add missing changes from Magento 2.3.0 blank theme

c0623bf

Januszpl force-pushed the feature/32702 branch from b5e27ce to c0623bf Compare May 23, 2019 01:51

#32702: add missing changes from Magento 2.3.0 blank theme update

18d6a50

anqaka previously approved these changes May 23, 2019

View reviewed changes

Merge branch 'develop' into feature/32702

baa9616

Januszpl dismissed anqaka’s stale review via baa9616 May 23, 2019 19:22

anqaka approved these changes May 23, 2019

View reviewed changes

Januszpl merged commit f77ae92 into develop May 23, 2019

Igloczek deleted the feature/32702 branch July 16, 2019 16:44

Igloczek mentioned this pull request Oct 28, 2021

Email styling issue SnowdogApps/magento2-alpaca-theme#130

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add email styles support #153

Add email styles support #153

Januszpl commented Aug 29, 2017 •

edited by Igloczek

Loading

Igloczek Sep 21, 2017

Januszpl Oct 13, 2017

Igloczek commented Sep 21, 2017

Igloczek left a comment

Januszpl commented Aug 2, 2018

Ig0r-M-magic42 Aug 15, 2018

Igloczek Aug 20, 2018

Januszpl Dec 8, 2018 •

edited

Loading

Januszpl commented Nov 26, 2018

Januszpl commented Nov 29, 2018 •

edited

Loading

Januszpl commented Mar 3, 2019 •

edited

Loading

Add email styles support #153

Add email styles support #153

Conversation

Januszpl commented Aug 29, 2017 • edited by Igloczek Loading

Igloczek Sep 21, 2017

Choose a reason for hiding this comment

Januszpl Oct 13, 2017

Choose a reason for hiding this comment

Igloczek commented Sep 21, 2017

Igloczek left a comment

Choose a reason for hiding this comment

Januszpl commented Aug 2, 2018

Ig0r-M-magic42 Aug 15, 2018

Choose a reason for hiding this comment

Igloczek Aug 20, 2018

Choose a reason for hiding this comment

Januszpl Dec 8, 2018 • edited Loading

Choose a reason for hiding this comment

Januszpl commented Nov 26, 2018

Januszpl commented Nov 29, 2018 • edited Loading

Januszpl commented Mar 3, 2019 • edited Loading

Januszpl commented Aug 29, 2017 •

edited by Igloczek

Loading

Januszpl Dec 8, 2018 •

edited

Loading

Januszpl commented Nov 29, 2018 •

edited

Loading

Januszpl commented Mar 3, 2019 •

edited

Loading