This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Email styles fix backport to v1.1.3 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on (without suffix) and for inline version with "-inline" suffix, fix compilation errors with missing/wrong variables name, import in email.scss module email styles only from Magento_Bundle, Magento_Rma, Magento_Sales modules as it's in the magento blank theme
…cks for email clients
…e list edited manually if needed
…o2-theme-blank-sass into feature/32702 * 'feature/32702' of https://github.com/SnowdogApps/magento2-theme-blank-sass: #32911: make breakpoints consistent across the sass fiels Accept any version of magento/framework
…disabling rules from email sass files
… lint in _email-base.scss
Conflicts: Magento_Sales/styles/_email.scss styles/vendor/magento-ui/variables/_email.scss styles/vendor/magento-ui/variables/_messages.scss
…ture more similar to less version, move variables imports to variables partial
…w typography as icons use typography defined variable (font name)
…ed previously in LESS to SASS porting commit (fd0ffcc)
…ons below typography as icons use typography defined variable (font name)" This reverts commit 61e64ec.
…ke structure more similar to less version, move variables imports to variables partial" This reverts commit ba79372.
… access to variable in email file
anqaka
reviewed
May 15, 2019
| ## Email styles support | ||
| * for Magento < 2.3.0 requires to run something like email-fix task added to Frontools in [ver 1.6.0](https://github.com/SnowdogApps/magento2-frontools/tree/1.6.0) | ||
| [Related issue](https://github.com/MyIntervals/emogrifier/issues/296) | ||
|
|
There was a problem hiding this comment.
should be addded information how to customise email in theme
| text-decoration: $link__visited__text-decoration !important; // sass-lint:disable-line no-important | ||
| } | ||
|
|
||
| a:hover { |
There was a problem hiding this comment.
missing focus state, and IMO should be underline on hover
|
|
||
| a:active, | ||
| a:hover, | ||
| a:visited { |
added 5 commits
July 6, 2019 21:56
…email-inline.scss files as in sass version we make manual imports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #153 to v.1.1
Require using frontools 1.6.0 and gulp email-fix as if this fix task won't be applied we will have
without email fix:
after gulp styles and email fix or gulp styles --prod and email-fix --prod
