Parachain Relayer V2 #1321
Open
Parachain Relayer V2 #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgeddes
reviewed
Oct 24, 2024
relayer/relays/parachain/types_v2.go
Outdated
| Fee types.U128 | ||
| Nonce uint64 | ||
| BlockNumber uint32 | ||
| Fee big.Int |
There was a problem hiding this comment.
If you use types.UCompact then you won't need to write a custom decoder.
yrong
commented
Nov 4, 2024
relayer/relays/parachain/main.go
Outdated
| return fmt.Errorf("get block header: %w", err) | ||
| } | ||
|
|
||
| proof, err := relay.beaconHeader.FetchExecutionProof(*blockHeader.ParentBeaconRoot, false) |
There was a problem hiding this comment.
Generate delivery proof
* Update contracts for smoke tests * Remove unused * Decode test * Update subxt
Tested E2E flow register PNA work as expected. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## vincent/v2 #1321 +/- ##
==============================================
+ Coverage 65.29% 65.44% +0.14%
==============================================
Files 23 23
Lines 729 735 +6
Branches 122 123 +1
==============================================
+ Hits 476 481 +5
Misses 242 242
- Partials 11 12 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://linear.app/snowfork/issue/SNO-1230
Requires: yrong/polkadot-sdk#4