Fix S1125 FP: Type check for objects and dynamic types #8575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/Fix-S1125-FP-object-and-dynamic-types
branch
from
76862e0
to
162adf8
Compare
martin-strecker-sonarsource
requested changes
Jan 22, 2024
analyzers/src/SonarAnalyzer.Common/Rules/BooleanLiteralUnnecessaryBase.cs
Outdated
Show resolved
Hide resolved
martin-strecker-sonarsource
requested changes
Jan 23, 2024
| @@ -25,6 +25,8 @@ public abstract class BooleanLiteralUnnecessaryBase<TSyntaxKind> : SonarDiagnost | |||
| { | |||
| internal const string DiagnosticId = "S1125"; | |||
|
|
|||
| private INamedTypeSymbol[] systemBooleanInterfaces; | |||
There was a problem hiding this comment.
Suggested change
| private INamedTypeSymbol[] systemBooleanInterfaces; | |
| private ImmutableArray<INamedTypeSymbol> systemBooleanInterfaces; |
There was a problem hiding this comment.
You may also consider:
- Loading the interfaces in CompilationStart and pass it from there or
- Use a static
ConditionalWeakTable<Compilation, ImmutableArray<INamedTypeSymbol>>to store the interfaces between the instances of the analyzer.
| private bool TypeShouldBeIgnored(SyntaxNode node, SemanticModel model) | ||
| { | ||
| var type = model.GetTypeInfo(node).Type; | ||
| systemBooleanInterfaces ??= model.Compilation.GetTypeByMetadataName(KnownType.System_Boolean).Interfaces.ToArray(); |
There was a problem hiding this comment.
Suggested change
| systemBooleanInterfaces ??= model.Compilation.GetTypeByMetadataName(KnownType.System_Boolean).Interfaces.ToArray(); | |
| systemBooleanInterfaces ??= model.Compilation.GetTypeByMetadataName(KnownType.System_Boolean).Interfaces; |
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/Fix-S1125-FP-object-and-dynamic-types
branch
from
9369512
to
6c3bc93
Compare
|
|
martin-strecker-sonarsource
approved these changes
Jan 24, 2024
| return type.IsNullableBoolean() | ||
| || type is ITypeParameterSymbol | ||
| || type.Is(KnownType.System_Object) | ||
| || systemBooleanInterfaces.Any(x => x.Equals(type)); |
There was a problem hiding this comment.
FYI: Regarding symbol "Equals" there is some fun coming up, when we upgrade Roslyn:
dotnet/roslyn-analyzers#3427
Symbol equality comparison should be explicit about nullable annotation handling. Our version of Roslyn does not contain SymbolEqualityComparer.
zsolt-kolbay-sonarsource
deleted the
Zsolt/Fix-S1125-FP-object-and-dynamic-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7792