Fix S1125 FP: Type check for objects and dynamic types

analyzers/src/SonarAnalyzer.CSharp/Rules/BooleanLiteralUnnecessary.cs

@@ -66,6 +66,7 @@ protected override void Initialize(SonarAnalysisContext context)
             context.RegisterNodeAction(CheckNotEquals, SyntaxKind.NotEqualsExpression);
             context.RegisterNodeAction(CheckConditional, SyntaxKind.ConditionalExpression);
             context.RegisterNodeAction(CheckForLoopCondition, SyntaxKind.ForStatement);
+            base.Initialize(context);
         }
 
         private void CheckForLoopCondition(SonarSyntaxNodeReportingContext context)

analyzers/src/SonarAnalyzer.Common/Rules/BooleanLiteralUnnecessaryBase.cs

@@ -25,6 +25,8 @@ public abstract class BooleanLiteralUnnecessaryBase<TSyntaxKind> : SonarDiagnost
     {
         internal const string DiagnosticId = "S1125";
 
+        private ImmutableArray<INamedTypeSymbol> systemBooleanInterfaces;
+
         protected enum ErrorLocation
         {
             // The BooleanLiteral node is highlighted
@@ -46,6 +48,12 @@ protected enum ErrorLocation
         protected abstract bool IsTrue(SyntaxNode syntaxNode);
         protected abstract bool IsFalse(SyntaxNode syntaxNode);
 
+        protected override void Initialize(SonarAnalysisContext context) =>
+            context.RegisterCompilationStartAction(x =>
+            {
+                systemBooleanInterfaces = x.Compilation.GetTypeByMetadataName(KnownType.System_Boolean).Interfaces;
+            });
+
         // For C# 7 syntax
         protected virtual bool IsInsideTernaryWithThrowExpression(SyntaxNode syntaxNode) => false;
 
@@ -145,7 +153,9 @@ protected bool CheckForNullabilityAndBooleanConstantsReport(SonarSyntaxNodeRepor
             var left = Language.Syntax.RemoveParentheses(GetLeftNode(node));
             var right = Language.Syntax.RemoveParentheses(GetRightNode(node));
 
-            if (CheckForNullability(left, right, context.SemanticModel))
+            if (right is null // Avoids DeclarationPattern or RecursivePattern
+                || TypeShouldBeIgnored(left, context.SemanticModel)
+                || TypeShouldBeIgnored(right, context.SemanticModel))
             {
                 return true;
             }
@@ -205,9 +215,13 @@ private Location CalculateExtendedLocation(SyntaxNode parent, bool isLeftSide)
             return isLeftSide ? parent.CreateLocation(token) : token.CreateLocation(parent);
         }
 
-        private static bool CheckForNullability(SyntaxNode left, SyntaxNode right, SemanticModel model) =>
-            right is null // Avoids DeclarationPattern or RecursivePattern
-            || model.GetTypeInfo(left).Type.IsNullableBoolean()
-            || model.GetTypeInfo(right).Type.IsNullableBoolean();
+        private bool TypeShouldBeIgnored(SyntaxNode node, SemanticModel model)
+        {
+            var type = model.GetTypeInfo(node).Type;
+            return type.IsNullableBoolean()
+                || type is ITypeParameterSymbol
+                || type.Is(KnownType.System_Object)
+                || systemBooleanInterfaces.Any(x => x.Equals(type));
+        }
     }
 }

analyzers/src/SonarAnalyzer.VisualBasic/Rules/BooleanLiteralUnnecessary.cs

@@ -45,6 +45,7 @@ protected override void Initialize(SonarAnalysisContext context)
             context.RegisterNodeAction(CheckEquals, SyntaxKind.EqualsExpression);
             context.RegisterNodeAction(CheckNotEquals, SyntaxKind.NotEqualsExpression);
             context.RegisterNodeAction(CheckConditional, SyntaxKind.TernaryConditionalExpression);
+            base.Initialize(context);
         }
 
         private void CheckLogicalNot(SonarSyntaxNodeReportingContext context)

analyzers/tests/SonarAnalyzer.Test/TestCases/BooleanLiteralUnnecessary.CSharp8.Fixed.cs

@@ -18,4 +18,17 @@ public void Foo(string key)
             var x = (key is null) ? throw new ArgumentNullException(nameof(key)) : false;
         }
     }
+
+    // https://github.com/SonarSource/sonar-dotnet/issues/7792
+    class ConvertibleGenericTypes
+    {
+        void ConvertibleToBool<T1, T2, T3>(T1 unconstrained, T2 constrainedToStruct, T3 constrainedToBoolInterface)
+            where T2 : struct
+            where T3 : IComparable<bool>
+        {
+            if (unconstrained is true) { }
+            if (constrainedToStruct is true) { }
+            if (constrainedToBoolInterface is true) { }
+        }
+    }
 }

analyzers/tests/SonarAnalyzer.Test/TestCases/BooleanLiteralUnnecessary.CSharp8.cs

@@ -18,4 +18,17 @@ public void Foo(string key)
             var x = (key is null) ? throw new ArgumentNullException(nameof(key)) : false;
         }
     }
+
+    // https://github.com/SonarSource/sonar-dotnet/issues/7792
+    class ConvertibleGenericTypes
+    {
+        void ConvertibleToBool<T1, T2, T3>(T1 unconstrained, T2 constrainedToStruct, T3 constrainedToBoolInterface)
+            where T2 : struct
+            where T3 : IComparable<bool>
+        {
+            if (unconstrained is true) { }
+            if (constrainedToStruct is true) { }
+            if (constrainedToBoolInterface is true) { }
+        }
+    }
 }

analyzers/tests/SonarAnalyzer.Test/TestCases/BooleanLiteralUnnecessary.Fixed.cs

@@ -214,4 +214,22 @@ void Method(bool cond)
             if (cond) { } // Fixed
         }
     }
+
+    // https://github.com/SonarSource/sonar-dotnet/issues/7792
+    class ObjectIsBool
+    {
+        void Object(object obj, Exception exc)
+        {
+            if (obj is true) { }
+            if (exc.Data["SomeKey"] is true) { }
+        }
+
+        void ConvertibleToBool(IComparable comparable, IComparable<bool> comparableBool, IEquatable<bool> equatable, IConvertible convertible)
+        {
+            if (comparable is true) { }
+            if (comparableBool is true) { }
+            if (equatable is true) { }
+            if (convertible is true) { }
+        }
+    }
 }

analyzers/tests/SonarAnalyzer.Test/TestCases/BooleanLiteralUnnecessary.cs

@@ -231,4 +231,22 @@ void Method(bool cond)
             if (cond == false) { } // Noncompliant, TP but code fix is wrong - it should be fixed to "if (!cond)"
         }
     }
+
+    // https://github.com/SonarSource/sonar-dotnet/issues/7792
+    class ObjectIsBool
+    {
+        void Object(object obj, Exception exc)
+        {
+            if (obj is true) { }
+            if (exc.Data["SomeKey"] is true) { }
+        }
+
+        void ConvertibleToBool(IComparable comparable, IComparable<bool> comparableBool, IEquatable<bool> equatable, IConvertible convertible)
+        {
+            if (comparable is true) { }
+            if (comparableBool is true) { }
+            if (equatable is true) { }
+            if (convertible is true) { }
+        }
+    }
 }

analyzers/tests/SonarAnalyzer.Test/TestCases/BooleanLiteralUnnecessary.vb

@@ -182,8 +182,8 @@ Public Class BooleanLiteralUnnecessary
   End Sub
 
   Function BooleanMethod() As Boolean
-    Return True 
-  End Function
+        Return True
+    End Function
 
 End Class
 
@@ -220,3 +220,13 @@ Public Class Repro
         Return True
     End Function
 End Class
+
+' https://github.com/SonarSource/sonar-dotnet/issues/7792
+Class ObjectIsBool
+    Sub Method(obj As Object, exc As Exception)
+        If obj = True Then
+        End If
+        If exc.Data("SomeKey") = True Then
+        End If
+    End Sub
+End Class