Let's not build reactnativeutilsjni shared library #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We will not build the shared library named reactnativeutilsjni as it is built from the same sources as reactnativejni. It makes sense to remove the duplicate copy. This change should help reduce the
apksize for android apps.This is similar to a recently merged PR in main:
facebook#34339
Changelog
[Android][Changed] - Replaced reactnativeutilsjni with reactnativejni in the build process to reduce size
Test Plan
Built react-native 0.68 from source and it builds the
.aarsuccessfully.It has to be tested against: