-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing reactnativeutilsjni as it is built from the same sources as reactnativejni #34339
Conversation
…e sources as reactnativejni. Remove references of reactnativeutilsjni and replace them with reactnativejni
Removing reactnativeutilsjni as it is built from the same sources as reactnativejni
Hi @SparshaSaha! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: 2fa04be |
Base commit: 2fa04be |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Removed some TODO comments
@genkikondo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @SparshaSaha in 54a4fcb. When will my fix make it into a release? | Upcoming Releases |
…reactnativejni (#34339) Summary: This Pull Request aims at removing the making of reactnativeutilsjni as it is built from the same sources as reactnativejni. It also replaces references to reactnativeutilsjni with reactnativejni. This should get rid of `reactnativeutilsjni.so` while reusing `reactnativejni.so` in it's place. This should give us some size improvements in the finally built apk. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Changed] - Replaced reactnativeutilsjni with reactnativejni in the build process to reduce size Pull Request resolved: #34339 Test Plan: 1. Ran the CMakelist.txt file using CMake and I could see that reactnativeutilsjni.dir is no longer generated with my changes. 2. Built the aar from this branch in Android Studio and build happened successfully. I am not sure if we could run any more tests. Please let me know in case anymore testing is required and I can do accordingly Reviewed By: cortinico Differential Revision: D38400481 Pulled By: genkikondo fbshipit-source-id: 592736e56441328389ae89135667c336ff8018e6
…reactnativejni (facebook#34339) Summary: This Pull Request aims at removing the making of reactnativeutilsjni as it is built from the same sources as reactnativejni. It also replaces references to reactnativeutilsjni with reactnativejni. This should get rid of `reactnativeutilsjni.so` while reusing `reactnativejni.so` in it's place. This should give us some size improvements in the finally built apk. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Changed] - Replaced reactnativeutilsjni with reactnativejni in the build process to reduce size Pull Request resolved: facebook#34339 Test Plan: 1. Ran the CMakelist.txt file using CMake and I could see that reactnativeutilsjni.dir is no longer generated with my changes. 2. Built the aar from this branch in Android Studio and build happened successfully. I am not sure if we could run any more tests. Please let me know in case anymore testing is required and I can do accordingly Reviewed By: cortinico Differential Revision: D38400481 Pulled By: genkikondo fbshipit-source-id: 592736e56441328389ae89135667c336ff8018e6
…reactnativejni (facebook#34339) Summary: This Pull Request aims at removing the making of reactnativeutilsjni as it is built from the same sources as reactnativejni. It also replaces references to reactnativeutilsjni with reactnativejni. This should get rid of `reactnativeutilsjni.so` while reusing `reactnativejni.so` in it's place. This should give us some size improvements in the finally built apk. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Changed] - Replaced reactnativeutilsjni with reactnativejni in the build process to reduce size Pull Request resolved: facebook#34339 Test Plan: 1. Ran the CMakelist.txt file using CMake and I could see that reactnativeutilsjni.dir is no longer generated with my changes. 2. Built the aar from this branch in Android Studio and build happened successfully. I am not sure if we could run any more tests. Please let me know in case anymore testing is required and I can do accordingly Reviewed By: cortinico Differential Revision: D38400481 Pulled By: genkikondo fbshipit-source-id: 592736e56441328389ae89135667c336ff8018e6
…reactnativejni (#34339) Summary: This Pull Request aims at removing the making of reactnativeutilsjni as it is built from the same sources as reactnativejni. It also replaces references to reactnativeutilsjni with reactnativejni. This should get rid of `reactnativeutilsjni.so` while reusing `reactnativejni.so` in it's place. This should give us some size improvements in the finally built apk. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Changed] - Replaced reactnativeutilsjni with reactnativejni in the build process to reduce size Pull Request resolved: #34339 Test Plan: 1. Ran the CMakelist.txt file using CMake and I could see that reactnativeutilsjni.dir is no longer generated with my changes. 2. Built the aar from this branch in Android Studio and build happened successfully. I am not sure if we could run any more tests. Please let me know in case anymore testing is required and I can do accordingly Reviewed By: cortinico Differential Revision: D38400481 Pulled By: genkikondo fbshipit-source-id: 592736e56441328389ae89135667c336ff8018e6
Summary
This Pull Request aims at removing the making of reactnativeutilsjni as it is built from the same sources as reactnativejni. It also replaces references to reactnativeutilsjni with reactnativejni.
This should get rid of
reactnativeutilsjni.so
while reusingreactnativejni.so
in it's place. This should give us some size improvements in the finally built apk.Changelog
[Android] [Changed] - Replaced reactnativeutilsjni with reactnativejni in the build process to reduce size
Test Plan
I am not sure if we could run any more tests. Please let me know in case anymore testing is required and I can do accordingly