Should not log error if TestAssembly does not have a RuntimePlugin at…

…tribute (#2462) * Should not log error if TestAssembly does not have a RuntimePlugin attribute * Update changelog * Remove Debugger
SpecFlowOSS · Jul 13, 2021 · 31d3cc2 · 31d3cc2
1 parent af4319f
commit 31d3cc2
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 9 deletions.
diff --git a/TechTalk.SpecFlow/Infrastructure/ContainerBuilder.cs b/TechTalk.SpecFlow/Infrastructure/ContainerBuilder.cs
@@ -146,16 +146,23 @@ protected virtual void LoadPlugins(IRuntimeConfigurationProvider configurationPr
             var traceListener = container.Resolve<ITraceListener>();
             foreach (var pluginPath in pluginLocator.GetAllRuntimePlugins())
             {
-                LoadPlugin(pluginPath, pluginLoader, runtimePluginEvents, unitTestProviderConfigration, traceListener);
+                // Should not log error if TestAssembly does not have a RuntimePlugin attribute
+                var traceMissingPluginAttribute = !testAssembly.Location.Equals(pluginPath);
+                LoadPlugin(pluginPath, pluginLoader, runtimePluginEvents, unitTestProviderConfigration, traceListener, traceMissingPluginAttribute);
             }
         }
 
-        protected virtual void LoadPlugin(string pluginPath, IRuntimePluginLoader pluginLoader, RuntimePluginEvents runtimePluginEvents,
-            UnitTestProviderConfiguration unitTestProviderConfigration, ITraceListener traceListener)
+        protected virtual void LoadPlugin(
+            string pluginPath,
+            IRuntimePluginLoader pluginLoader,
+            RuntimePluginEvents runtimePluginEvents,
+            UnitTestProviderConfiguration unitTestProviderConfigration,
+            ITraceListener traceListener,
+            bool traceMissingPluginAttribute)
         {
             traceListener.WriteToolOutput($"Loading plugin {pluginPath}");
 
-            var plugin = pluginLoader.LoadPlugin(pluginPath, traceListener);
+            var plugin = pluginLoader.LoadPlugin(pluginPath, traceListener, traceMissingPluginAttribute);
             var runtimePluginParameters = new RuntimePluginParameters();
 
             plugin?.Initialize(runtimePluginEvents, runtimePluginParameters, unitTestProviderConfigration);

diff --git a/TechTalk.SpecFlow/Plugins/IRuntimePluginLoader.cs b/TechTalk.SpecFlow/Plugins/IRuntimePluginLoader.cs
@@ -6,6 +6,6 @@ namespace TechTalk.SpecFlow.Plugins
 {
     public interface IRuntimePluginLoader
     {
-        IRuntimePlugin LoadPlugin(string pluginAssemblyName, ITraceListener traceListener);
+        IRuntimePlugin LoadPlugin(string pluginAssemblyName, ITraceListener traceListener, bool traceMissingPluginAttribute);
     }
 }
diff --git a/TechTalk.SpecFlow/Plugins/RuntimePluginLoader.cs b/TechTalk.SpecFlow/Plugins/RuntimePluginLoader.cs
@@ -6,7 +6,7 @@ namespace TechTalk.SpecFlow.Plugins
 {
     public class RuntimePluginLoader : IRuntimePluginLoader
     {
-        public IRuntimePlugin LoadPlugin(string pluginAssemblyName, ITraceListener traceListener)
+        public IRuntimePlugin LoadPlugin(string pluginAssemblyName, ITraceListener traceListener, bool traceMissingPluginAttribute)
         {
             Assembly assembly;
             try
@@ -25,7 +25,9 @@ public IRuntimePlugin LoadPlugin(string pluginAssemblyName, ITraceListener trace
             var pluginAttribute = (RuntimePluginAttribute)Attribute.GetCustomAttribute(assembly, typeof(RuntimePluginAttribute));
             if (pluginAttribute == null)
             {
-                traceListener.WriteToolOutput(string.Format("Missing [assembly:RuntimePlugin] attribute in {0}. Please check https://go.specflow.org/doc-plugins for details.", assembly.FullName));
+                if (traceMissingPluginAttribute)
+                    traceListener.WriteToolOutput(string.Format("Missing [assembly:RuntimePlugin] attribute in {0}. Please check https://go.specflow.org/doc-plugins for details.", assembly.FullName));
+
                 return null;
             }
 

diff --git a/Tests/TechTalk.SpecFlow.PluginTests/Infrastructure/WindsorPluginTests.cs b/Tests/TechTalk.SpecFlow.PluginTests/Infrastructure/WindsorPluginTests.cs
@@ -24,7 +24,7 @@ public void Can_load_Windsor_plugin()
             var loader = new RuntimePluginLoader();
             var listener = new Mock<ITraceListener>();
 
-            var plugin = loader.LoadPlugin("SpecFlow.Windsor.SpecFlowPlugin.dll", listener.Object);
+            var plugin = loader.LoadPlugin("SpecFlow.Windsor.SpecFlowPlugin.dll", listener.Object, It.IsAny<bool>());
 
             plugin.Should().NotBeNull();
         }

diff --git a/Tests/TechTalk.SpecFlow.RuntimeTests/Infrastructure/PluginTests.cs b/Tests/TechTalk.SpecFlow.RuntimeTests/Infrastructure/PluginTests.cs
@@ -313,7 +313,7 @@ public override void RegisterGlobalContainerDefaults(BoDi.ObjectContainer contai
 
             var pluginLoaderStub = new Mock<IRuntimePluginLoader>();
             var traceListener = container.Resolve<ITraceListener>();
-            pluginLoaderStub.Setup(pl => pl.LoadPlugin(It.IsAny<string>(), traceListener)).Returns(_pluginToReturn);
+            pluginLoaderStub.Setup(pl => pl.LoadPlugin(It.IsAny<string>(), traceListener, It.IsAny<bool>())).Returns(_pluginToReturn);
 
 
             container.RegisterInstanceAs<IRuntimePluginLocator>(runtimePluginLocator.Object);

diff --git a/changelog.txt b/changelog.txt
@@ -11,6 +11,7 @@ Changes:
 Fixes:
 + Fix Type or namespace [TestNamespace]_XunitAssemblyFixture could not be found #1825
 + Fix Default value deserialization from specflow.json #2239 #2439
++ Should not log error if TestAssembly does not have a RuntimePlugin attribute #2432
 
 
 3.8