Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not log error if TestAssembly does not have a RuntimePlugin attribute #2462

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Should not log error if TestAssembly does not have a RuntimePlugin attribute #2462

merged 3 commits into from
Jul 13, 2021

Conversation

epresi
Copy link
Contributor

@epresi epresi commented Jul 12, 2021 •
edited
Loading

Fixes #2432

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@epresi epresi changed the title Should not log error if TestAssembly does not have a RuntimePlugin at… Should not log error if TestAssembly does not have a RuntimePlugin attribute Jul 12, 2021
@epresi epresi requested a review from SabotageAndi July 12, 2021 13:01
@epresi epresi merged commit 31d3cc2 into master Jul 13, 2021
@epresi epresi deleted the 2427-missing-pluginattr-msg branch July 13, 2021 07:37
@tlecomte tlecomte mentioned this pull request Aug 2, 2021
Closed
Code-Grump pushed a commit to Code-Grump/SpecFlow that referenced this pull request Mar 29, 2023
@epresi @Code-Grump
Should not log error if TestAssembly does not have a RuntimePlugin at…
f292770 
…tribute (SpecFlowOSS#2462)

* Should not log error if TestAssembly does not have a RuntimePlugin attribute

* Update changelog

* Remove Debugger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabotageAndi SabotageAndi SabotageAndi approved these changes

@tzongithub tzongithub tzongithub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing [assembly:RuntimePlugin] with newly created project, without custom code.
3 participants
@epresi @SabotageAndi @tzongithub