Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore rule for external GitHub links to the links checker command. #332

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

andreySadomovskiy
Copy link
Collaborator

This PR brings changes to the links check task flow.

The GitHub rejects links checks from the html-proofer tool. The issue is described here. I added ignore rule for external GitHub links to avoid wrong error messages.

Copy link
Collaborator

@JuliaEvseeva JuliaEvseeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreySadomovskiy andreySadomovskiy merged commit d892672 into master Jul 14, 2020
@andreySadomovskiy andreySadomovskiy deleted the disable-links-checks-for-git-hub branch July 14, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants