Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error shown #226

Closed
leo opened this issue Jul 2, 2015 · 8 comments
Closed

Wrong error shown #226

leo opened this issue Jul 2, 2015 · 8 comments

Comments

@leo
Copy link

leo commented Jul 2, 2015

I don't understand why html-proofer shows me this error, the video is still online and accessible:

bildschirmfoto 2015-07-02 um 22 30 01

Here's the link: https://youtu.be/vEYKRhETy4A 🌀

Could you please check this?

@gjtorikian
Copy link
Owner

A 429 means that there have been too many requests made to that URL: http://stackoverflow.com/a/23367215/213345

If I had to guess, probably the link to the YouTube video is being tested far too often, and as a result, YouTube is not accepting more requests from html-proofer.

The solution for right now would be to mark the link as ignored, through href_ignore.

#223 might be an option in the future.

@leo
Copy link
Author

leo commented Jul 3, 2015

Thanks for the quick response! 😊

I searched for a Regex which filters for YouTube-links and found this one: ^(https?\:\/\/)?(www\.)?(youtube\.com|youtu\.?be)\/.+$

How can I pass it to the href_ignore parameter? Since it only takes an array of Strings or Regexes, I've tried the following:

--href_ignore [ ^(https?\:\/\/)?(www\.)?(youtube\.com|youtu\.?be)\/.+$ ]

But this doesn't seem to work. Should I put the Regex between two 's, or what did I do wrong?

@doktorbro
Copy link

doktorbro commented Jul 3, 2015 via email

@leo
Copy link
Author

leo commented Jul 4, 2015

@penibelst I've followed the description on the Stack Overflow article and wrapped the Regex in in non-escaped forward slashes (the other forward slashes we're already escaped):

--href_ignore /^(https?\:\/\/)?(www\.)?(youtube\.com|youtu\.?be)\/.+$/

However it still doesn't work. What did I do wrong? Here's the log from Travis CI.

@doktorbro
Copy link

The CLI option is --href-ignore. Note the hyphen in the middle.

leo added a commit to leo/site that referenced this issue Jul 5, 2015
@leo
Copy link
Author

leo commented Jul 5, 2015

What? It's still not working. I must be missing something obvious here.

Screenshot

@doktorbro
Copy link

For ignoring links that start with https://youtu.be/ use

htmlproof ./_site --href-ignore /^https:\/\/youtu\.be\//

@leo
Copy link
Author

leo commented Jul 5, 2015

Yeeehaa! It works — finally! Thanks you, @penibelst! 😀

Looks like the previous Regex was a bit broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants