Remove type reference from (by) option
#311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
============================================
+ Coverage 74.23% 74.75% +0.51%
+ Complexity 2387 2376 -11
============================================
Files 387 386 -1
Lines 9945 9843 -102
Branches 606 590 -16
============================================
- Hits 7383 7358 -25
+ Misses 2401 2323 -78
- Partials 161 162 +1 |
…' into no-wildcard-in-by
…' into no-wildcard-in-by
…option' into no-wildcard-in-by
…option' into no-wildcard-in-by
…' into no-wildcard-in-by
…-in-by # Conflicts: # base/src/main/java/io/spine/code/proto/FieldOption.java # base/src/main/java/io/spine/validate/FieldValidatingOption.java # base/src/main/java/io/spine/validate/FieldValidator.java # base/src/main/java/io/spine/validate/MaxConstraint.java # base/src/main/java/io/spine/validate/MinConstraint.java
…-in-by # Conflicts: # base/src/main/java/io/spine/validate/NumericFieldConstraint.java
Also: simplify method names
Also: * Test external validation constraint passed via patch by @dmytro-grankin
…-in-by # Conflicts: # tools/model-compiler/src/main/java/io/spine/tools/compiler/enrichment/EnrichmentMapBuilder.java
…-in-by # Conflicts: # base/src/main/proto/spine/options.proto
|
@armiol, @yuri-sergiichuk, PTAL. |
armiol
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the way enrichment types are defined:
(enrichment_for)option.(by)option is no longer allowed. (See Drop support of nested enrichments and FQN (by) option #310.)Other notable changes:
FieldContextmoved to thecode.protopackage.FieldContextmethods were renamed avoiding thegetprefix.