Expose protocol version for status pings #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephan-gh
added a commit
to Minecrell/ServerListPlus
that referenced
this pull request
Apr 14, 2023
On SpongeAPI 10 the implementation-specific code does not work anymore. To fix this once and for all try to do it via proper APIs instead. NOTE: This is not supported in SpongeAPI yet. Until this is merged copy the modified interfaces to the stub source set to allow compiling. See SpongePowered/SpongeAPI#2456
stephan-gh
force-pushed
the
status-protocol
branch
from
b4a5c53
to
38204cc
Compare
ImMorpheus
requested changes
Apr 22, 2023
src/main/java/org/spongepowered/api/event/server/ClientPingServerEvent.java
Show resolved
Hide resolved
Historically we considered the Minecraft protocol versions as "implementation detail" that should not be exposed in SpongeAPI. However, since the addition of the status ping API 8 years ago the protocol version still exists exactly the same way, and there are use cases for checking it (identifying the exact client version) and modifying it (making the server appear as incompatible to clients). Right now plugins have to resort to using implementation-specific code for this, which is complicated and now hopelessly broken for api-10 (due to internal changes in the Minecraft code). Make it possible to check and modify the server version to fix this once and for all.
stephan-gh
force-pushed
the
status-protocol
branch
from
38204cc
to
22f6fbb
Compare
ImMorpheus
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically we considered the Minecraft protocol versions as "implementation detail" that should not be exposed in SpongeAPI.
However, since the addition of the status ping API 8 years ago (#367) the protocol version still exists exactly the same way, and there are use cases for checking it (identifying the exact client version) and modifying it (making the server appear as incompatible to clients).
Right now plugins have to resort to using implementation-specific code for this, which is complicated and now hopelessly broken for api-10 (due to internal changes in the Minecraft code).
Make it possible to check and modify the server version to fix this once and for all.
Closes #2251