Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose protocol version for status pings #2456

Merged
merged 1 commit into from
Apr 22, 2023

Commits on Apr 22, 2023

  1. Expose protocol version for status pings

    Historically we considered the Minecraft protocol versions as
    "implementation detail" that should not be exposed in SpongeAPI.
    
    However, since the addition of the status ping API 8 years ago the
    protocol version still exists exactly the same way, and there are
    use cases for checking it (identifying the exact client version) and
    modifying it (making the server appear as incompatible to clients).
    
    Right now plugins have to resort to using implementation-specific code
    for this, which is complicated and now hopelessly broken for api-10
    (due to internal changes in the Minecraft code).
    
    Make it possible to check and modify the server version to fix this
    once and for all.
    stephan-gh committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    22f6fbb View commit details
    Browse the repository at this point in the history