Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added debug logs for series lookup issues #110

Merged
merged 2 commits into from
Mar 23, 2019
Merged

Added debug logs for series lookup issues #110

merged 2 commits into from
Mar 23, 2019

Conversation

jkohen
Copy link
Contributor

@jkohen jkohen commented Mar 22, 2019

Debug logs will be added whenever the prometheus_sidecar/dropped_series metric is incremented. This also increases test coverage of the error paths.

This should help users debug issues caused by incorrect configuration, including:

  • Removal or modification of the job and instance labels.
  • Unsupported service discovery.
  • Missing metric type metadata.

These are debug level instead of warning, because they will be logged for each failing series every time they are refreshed (every 3 minutes by default).

Closes #109
/cc @Dnefedkin

@jkohen jkohen requested a review from StevenYCChou March 22, 2019 11:37
Copy link
Contributor

@StevenYCChou StevenYCChou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request change on error handling ordering.

the initialization shortening is optional, but I think it will reduce line # and hence the time to consume the code.

retrieval/series_cache_test.go Outdated Show resolved Hide resolved
retrieval/series_cache_test.go Outdated Show resolved Hide resolved
retrieval/series_cache_test.go Outdated Show resolved Hide resolved
retrieval/series_cache_test.go Outdated Show resolved Hide resolved
retrieval/series_cache_test.go Show resolved Hide resolved
retrieval/series_cache_test.go Outdated Show resolved Hide resolved
retrieval/series_cache_test.go Show resolved Hide resolved
retrieval/series_cache_test.go Show resolved Hide resolved
retrieval/series_cache_test.go Show resolved Hide resolved
@jkohen jkohen requested a review from StevenYCChou March 23, 2019 01:15
@jkohen jkohen merged commit 3c176b3 into master Mar 23, 2019
@jkohen jkohen deleted the extra_logs branch March 23, 2019 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log when the metadata lookup fails
3 participants