Resolves GCP API calls for monitoring.googleapis.com to set of IPs #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkohen
reviewed
Feb 27, 2019
jkohen
suggested changes
Mar 26, 2019
jkohen
suggested changes
May 8, 2019
bmoyles0117
reviewed
May 8, 2019
| @@ -120,6 +127,11 @@ func (c *Client) getConnection(ctx context.Context) (*grpc.ClientConn, error) { | |||
| if len(c.url.Port()) > 0 { | |||
| address = fmt.Sprintf("%s:%s", address, c.url.Port()) | |||
| } | |||
| if c.resolver != nil { | |||
| address = c.resolver.Scheme() + ":///" + address | |||
There was a problem hiding this comment.
What is c.resolver.Scheme() here? It seems like it wouldn't be an address, like what exists above on line 128.
There was a problem hiding this comment.
Some info here puts it better than I could: https://chromium.googlesource.com/external/github.com/grpc/grpc/+/v1.8.5/doc/naming.md The actual scheme is just a random series of letters. Most of what I know is that doc and the fact that we need it for dns. Let me know if you have other questions and I'll answer the best I can.
…er-prometheus-sidecar into nina-marie-sidecar
jkohen
suggested changes
May 10, 2019
jkohen
approved these changes
May 10, 2019
bmoyles0117
reviewed
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.