Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves GCP API calls for monitoring.googleapis.com to set of IPs #94
Resolves GCP API calls for monitoring.googleapis.com to set of IPs #94
Changes from 21 commits
dd82c99
2a9ff19
9d6fa41
f9ac371
8189652
f2d439b
add94b3
ca4f3fa
144cfa8
bb2d5f5
b34b93a
78c0f45
496f013
72f54cd
1415266
9b6d045
876c8f2
5e24716
3e6a38d
db5320f
9ee7507
4a43e39
41d461e
8db8e42
16efcbf
6a458d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is
c.resolver.Scheme()
here? It seems like it wouldn't be an address, like what exists above on line 128.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some info here puts it better than I could: https://chromium.googlesource.com/external/github.com/grpc/grpc/+/v1.8.5/doc/naming.md The actual scheme is just a random series of letters. Most of what I know is that doc and the fact that we need it for dns. Let me know if you have other questions and I'll answer the best I can.