Handle Education Video fetching failure with content unavailable view #90
Conversation
PaulGoldschmidt
changed the title
|
Thank you for that helpful suggestion, I really appreciate your feedback! I've added another condition at the Thanks alot! |
|
Seperating the filtering logic for sure benefits the readability and (I would assume) have a less performance overhead. |
|
Yikes, I've just realized that commit signing wasn't configured fully in my Xcode instance on the new hardware. I propose closing this pull request and submitting a new one with properly signed commits if that works for you. Sorry! |
No worries - feel free to either force-push this branch or open a new PR, whichever is easier! |
PaulGoldschmidt
force-pushed
the
main
branch
from
c0d48d7
to
eb43176
Compare
…nce with issue StanfordBDHG#84: Update Education view to handle empty video collections and modification of VideoList to display message when no videos are available
… check to catch that the videoCollections is empty.
PaulGoldschmidt
force-pushed
the
main
branch
from
eb43176
to
97dcd6c
Compare
|
Done, forced pushed and reenabled commit signing :) |
|
Perfect - thank you! 😊 I'm not sure whether the CI pipeline will be successful, but once #92 is merged, we should be able to merge the main branch into this one and it should work out fine! I will try to make that happen by EOD and let you know! |
|
Seems like the UI tests are failing because the buttons for different tabs are not found - from what I can tell, these issues don't seem directly related to the changes in this PR. I'll keep an eye on the test results over the next few days and dig deeper if the problems persist. If anyone has insights or wants me to take a closer look at the test outputs and the tests directly, just let me know. |
|
The tests are failing because the app is not able to automatically sign in for some reason. As I couldn't find the root cause of the problem, I'm trying to just recreate the changes made here in a separate PR. Since the pipelines of #94 seem to be working fine, I'm thinking maybe this is related to the changes coming from a fork? I will investigate further, just wanted to give a quick update. |
|
I think it might be related to secrets access of the CI when running with the changes from your fork. For now, I have duplicated the changes in #94, I hope it is fine for you if we merge it like that, sorry 😅 If you want to make further changes to this repository, please let us know and we may be able to grant you write access to the repository, so that you can work directly on it rather than working on a fork. CC: @PSchmiedmayer |
|
Hi @pauljohanneskraft, thanks for digging into this issue - I was suspecting something like missing secrets (we're not the first to experience this kind of issue), I assume reopening this PR just like you've done is the best approch here. While this minor improvement was a great introduction to SPEZI, I'll be focusing my contributions mainly on the framework itself going forward. I'll let you know if I need write access in the future. |
# Add ContentUnavailableView to Education page ## ♻️ Current situation & Problem This is just a copy of the changes made in #90 - This is mostly trying to debug why tests are failing by simply recreating the same changes and checking if the CI reacts differently here... ## ⚙️ Release Notes - Handle Education Video fetching failure with content unavailable view (#90) by @PaulGoldschmidt ## 📚 Documentation *Please ensure that you properly document any additions in conformance to [Spezi Documentation Guide](https://github.com/StanfordSpezi/.github/blob/main/DOCUMENTATIONGUIDE.md).* *You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.* ## ✅ Testing *Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.* *This section describes important information about the tests and why some elements might not be testable.* ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Handle Education Video fetching failure with content unavailable view with ContentUnavailableView
♻️ Current situation & Problem
This PR implements the ContentUnavailableView for the education video fetching failure(s) and should fix the issue #84.
⚙️ Release Notes
The Education tab now displays a "Content Unavailable" view when no educational videos are present, improving user feedback. Empty video collections are filtered out, ensuring users only see sections with actual content 🎥.
✅ Testing
Tests pass just fine (iOS 17.4)
🚸 Info
This is my first PR in this project, I'm happy for any improvments and feedback for my code {style} 🙆♂️
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: