Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Auth Flow with Firebase Functions Submodule #92

Merged
merged 62 commits into from
Sep 16, 2024

Conversation

pauljohanneskraft
Copy link
Contributor

New Auth Flow with Firebase Functions Submodule

♻️ Current situation & Problem

Combines #86 with #89 to hopefully resolve issues faster.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@pauljohanneskraft pauljohanneskraft mentioned this pull request Sep 13, 2024
1 task
@pauljohanneskraft
Copy link
Contributor Author

pauljohanneskraft commented Sep 13, 2024

This PR is currently blocked by the following PRs:

After they have been merged, we can release respective versions and then specify them in ENGAGE-HF-iOS.

@pauljohanneskraft pauljohanneskraft mentioned this pull request Sep 13, 2024
1 task
@pauljohanneskraft pauljohanneskraft self-assigned this Sep 13, 2024
@pauljohanneskraft pauljohanneskraft added the enhancement New feature or request label Sep 13, 2024
@pauljohanneskraft pauljohanneskraft changed the base branch from fix/add-submodule to main September 13, 2024 01:48
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 86.25000% with 44 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (7c1ff46) to head (a2c9a37).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ENGAGEHF/SharedExtensions/Account+Binding.swift 64.52% 11 Missing ⚠️
ENGAGEHF/Onboarding/InvitationCodeView.swift 66.67% 9 Missing ⚠️
ENGAGEHF/ContentView.swift 89.05% 8 Missing ⚠️
ENGAGEHF/Onboarding/AccountOnboarding.swift 50.00% 5 Missing ⚠️
ENGAGEHF/Account/InvitationCodeModule.swift 63.64% 4 Missing ⚠️
ENGAGEHF/Account/NotificationSettingsView.swift 96.00% 2 Missing ⚠️
...Managers/NavigationManager/NavigationManager.swift 88.24% 2 Missing ⚠️
...gers/NotificationManager/NotificationManager.swift 83.34% 2 Missing ⚠️
...SharedExtensions/AccountNotifications+Extras.swift 95.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   76.68%   78.33%   +1.66%     
==========================================
  Files         143      145       +2     
  Lines        5063     5002      -61     
==========================================
+ Hits         3882     3918      +36     
+ Misses       1181     1084      -97     
Files with missing lines Coverage Δ
ENGAGEHF/Account/AccountSheet.swift 100.00% <100.00%> (+27.28%) ⬆️
ENGAGEHF/Account/AdditionalAccountSections.swift 100.00% <ø> (ø)
ENGAGEHF/ENGAGEHF.swift 100.00% <100.00%> (ø)
ENGAGEHF/ENGAGEHFDelegate.swift 97.30% <100.00%> (+0.75%) ⬆️
ENGAGEHF/ENGAGEHFTestingSetup.swift 95.84% <100.00%> (ø)
ENGAGEHF/Home.swift 95.46% <ø> (+5.46%) ⬆️
...nagers/MedicationsManager/MedicationsManager.swift 71.59% <100.00%> (+1.32%) ⬆️
...AGEHF/Managers/MessageManager/MessageManager.swift 72.68% <100.00%> (+1.42%) ⬆️
...HF/Managers/UserMetaDataManager/Organization.swift 82.36% <ø> (ø)
...gers/UserMetaDataManager/UserMetaDataManager.swift 90.00% <100.00%> (+11.22%) ⬆️
... and 14 more

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1ff46...a2c9a37. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing for all the work here to incorporate @nriedman's work and all the account improvements; looks great!

@pauljohanneskraft pauljohanneskraft merged commit c8cf7ae into main Sep 16, 2024
7 checks passed
@pauljohanneskraft pauljohanneskraft deleted the feature/new-auth-flow-with-submodules branch September 16, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants