-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AccountKeyRequirement.manual
#75
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 84.49% 84.36% -0.12%
==========================================
Files 120 120
Lines 5213 5221 +8
==========================================
Hits 4404 4404
- Misses 809 817 +8
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for implementing this 🚀
Only had a small discussion of thinking again about how to name it (sorry for the meta-discussion at that point 🙊).
Sources/SpeziAccount/AccountValue/Configuration/AccountKeyRequirement.swift
Outdated
Show resolved
Hide resolved
Sources/SpeziAccount/AccountValue/Configuration/ConfiguredAccountKey.swift
Show resolved
Hide resolved
AccountKeyRequirement.hidden
AccountKeyRequirement.manual
Add
AccountKeyRequirement.manual
♻️ Current situation & Problem
There is currently no way to add AccountKeys that shouldn't be shown to the user. Since this might still be reasonable though (e.g. to check a status of the user like enrollment in a study), we introduce
AccountKeyRequirement.manual
.⚙️ Release Notes
AccountKeyRequirement.manual
to allow account keys that are not automatically shown to the user, either used entirely internally or exposed by custom UI elements.📚 Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.
✅ Testing
Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: