Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccountKeyRequirement.manual #75

Merged
merged 8 commits into from
Sep 15, 2024
Merged

Add AccountKeyRequirement.manual #75

merged 8 commits into from
Sep 15, 2024

Conversation

pauljohanneskraft
Copy link
Contributor

@pauljohanneskraft pauljohanneskraft commented Sep 12, 2024

Add AccountKeyRequirement.manual

♻️ Current situation & Problem

There is currently no way to add AccountKeys that shouldn't be shown to the user. Since this might still be reasonable though (e.g. to check a status of the user like enrollment in a study), we introduce AccountKeyRequirement.manual.

⚙️ Release Notes

  • Add AccountKeyRequirement.manual to allow account keys that are not automatically shown to the user, either used entirely internally or exposed by custom UI elements.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@pauljohanneskraft pauljohanneskraft self-assigned this Sep 12, 2024
@pauljohanneskraft pauljohanneskraft added the enhancement New feature or request label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (7e78ee9) to head (c2d3c3d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ountValue/Configuration/ConfiguredAccountKey.swift 66.67% 3 Missing ⚠️
...ue/Configuration/AccountKeyConfigurationImpl.swift 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   84.49%   84.36%   -0.12%     
==========================================
  Files         120      120              
  Lines        5213     5221       +8     
==========================================
  Hits         4404     4404              
- Misses        809      817       +8     
Files with missing lines Coverage Δ
...count/ViewModel/AccountOverviewFormViewModel.swift 91.26% <100.00%> (ø)
...Account/ViewModifier/AccountRequiredModifier.swift 88.47% <ø> (-1.92%) ⬇️
.../ViewModifier/DisableFieldAssistantsModifier.swift 100.00% <ø> (ø)
...ue/Configuration/AccountKeyConfigurationImpl.swift 34.38% <50.00%> (-2.29%) ⬇️
...ountValue/Configuration/ConfiguredAccountKey.swift 60.00% <66.67%> (-3.15%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e78ee9...c2d3c3d. Read the comment docs.

Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for implementing this 🚀

Only had a small discussion of thinking again about how to name it (sorry for the meta-discussion at that point 🙊).

@pauljohanneskraft pauljohanneskraft changed the title Add AccountKeyRequirement.hidden Add AccountKeyRequirement.manual Sep 13, 2024
@Supereg Supereg merged commit 397a55a into main Sep 15, 2024
11 of 13 checks passed
@Supereg Supereg deleted the add-hidden-requirement branch September 15, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants