Skip to content

Commit

Permalink
Merge pull request #1009 from StanfordVL/fix-profiling
Browse files Browse the repository at this point in the history
Fix profiling, remove unnecessary CI steps
  • Loading branch information
cgokmen authored Dec 11, 2024
2 parents 4a3ee62 + ae931b9 commit c83956f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 23 deletions.
19 changes: 2 additions & 17 deletions .github/workflows/examples-as-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,18 @@ jobs:
shell: micromamba run -n omnigibson /bin/bash -leo pipefail {0}
steps:
- name: Checkout source
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
submodules: true
path: omnigibson-src

- name: Install
working-directory: omnigibson-src
run: pip install -e .[dev,primitives]

- name: Generate example tests
working-directory: omnigibson-src
run: python tests/create_tests_of_examples.py

- name: Get list of generated tests
id: get-test-list
working-directory: omnigibson-src
run: |
echo "example_tests=$(cat tests/example_tests.json)" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -69,17 +65,14 @@ jobs:
run: echo "HOME=/root" >> $GITHUB_ENV

- name: Checkout source
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
submodules: true
path: omnigibson-src

- name: Install
working-directory: omnigibson-src
run: pip install -e .[dev,primitives]

- name: Run tests
working-directory: omnigibson-src
run: pytest -s tests/tests_of_examples/${{ matrix.test_file }}.py --junitxml=${{ matrix.test_file }}.xml && cp ${{ matrix.test_file }}.xml ${GITHUB_WORKSPACE}/

- name: Deploy artifact
Expand All @@ -99,20 +92,12 @@ jobs:
shell: micromamba run -n omnigibson /bin/bash -leo pipefail {0}
needs: [run_test]
steps:
- name: Checkout source
uses: actions/checkout@v2
with:
submodules: true
path: omnigibson-src
- name: Pull reports
uses: actions/download-artifact@v3
with:
path: omnigibson-src
- name: Example Test Report0
uses: dorny/test-reporter@v1
with:
name: Example Test Results
working-directory: omnigibson-src
path: ${{ github.run_id }}-tests-*/*_test.xml
reporter: java-junit
fail-on-error: 'true'
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/profiling.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,9 @@ jobs:
run: echo "HOME=/root" >> $GITHUB_ENV

- name: Checkout source
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
working-directory: omnigibson-src
run: pip install -e .[dev,primitives]

- name: Run performance benchmark
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,17 @@ jobs:

steps:
- name: Checkout source
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
submodules: true
path: omnigibson-src

- name: Install
working-directory: omnigibson-src
run: pip install -e .[dev,primitives] --no-build-isolation

- name: Print env
run: printenv

- name: Run tests
working-directory: omnigibson-src
run: pytest -s tests/${{ matrix.test_file }}.py --junitxml=${{ matrix.test_file }}.xml && cp ${{ matrix.test_file }}.xml ${GITHUB_WORKSPACE}/
continue-on-error: true

Expand Down

0 comments on commit c83956f

Please sign in to comment.