Fix/cypress #2

SuZhou-Joe · 2023-09-06T06:52:00Z

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

add license header Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

Signed-off-by: Hailong Cui <ihailong@amazon.com>

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

* feat: add workspace creator page Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: integrate with application workspace template Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add max-width and remove image wrapper if not exists Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: update filter condition to align with collapsible nav Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: validation & query Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: modify file name to reduce confusion Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add landing logic to retrive workspace id Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add worklist observable Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add worklist observable Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add worklist observable Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: make client more robust Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: use Subject Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

* feat: integrate with workspace create API Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: update to i18n text for toast Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add currentWorkspace$ Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add emit on currentWorkspace$ Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

Signed-off-by: Hailong Cui <ihailong@amazon.com>

Add workspace dropdown list --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> Co-authored-by: SuZhoue-Joe <suzhou@amazon.com>

* feat: init workspace menu stage 1 Signed-off-by: tygao <tygao@amazon.com> * fix: remove port diff Signed-off-by: tygao <tygao@amazon.com> * feat: update menu logic Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>

* fix import error Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix osd bootstrap failure Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>

* feat: add workspace overview page Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: move paths to common constants Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add workspace overview item by custom nav in start phase Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: change to currentWorkspace$ in workspace client Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>

…rch-project#23) Signed-off-by: Lin Wang <wonglam@amazon.com>

fix failed test snapshots temporary fix: fetch functional test from main branch fixed git error which cannot find ref due to feature branch `workspace` not exists on repo opensearch-dashboards-functional-test Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

) * change to currentWorkspace, wrap title using i18n Signed-off-by: zhichao-aws <zhichaog@amazon.com> * change import Signed-off-by: zhichao-aws <zhichaog@amazon.com> * directly return [] if currentWorkspace is null Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* feat: update workspace switch Signed-off-by: tygao <tygao@amazon.com> * fix: fix switch error Signed-off-by: tygao <tygao@amazon.com> * fix: fix prettier after merge Signed-off-by: tygao <tygao@amazon.com> * chore: remove extra code after merge Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>

codecov-commenter · 2023-09-06T07:55:27Z

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (afa373a) 65.72% compared to head (a6adcf0) 66.06%.

❗ Current head a6adcf0 differs from pull request most recent head 5e9a3f9. Consider uploading reports for the commit 5e9a3f9 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##           workspace       #2      +/-   ##
=============================================
+ Coverage      65.72%   66.06%   +0.34%     
=============================================
  Files           3336     3384      +48     
  Lines          64543    64906     +363     
  Branches       10285    10465     +180     
=============================================
+ Hits           42420    42882     +462     
+ Misses         19644    19453     -191     
- Partials        2479     2571      +92

Flag	Coverage Δ
Linux_	`66.06% <87.42%> (?)`
Linux_1	`?`
Linux_3	`?`
Windows_1	`?`
Windows_2	`?`
Windows_3	`?`
Windows_4	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/osd-pm/src/utils/package_json.ts	`66.66% <ø> (ø)`
packages/osd-pm/src/utils/project.ts	`66.26% <100.00%> (+4.62%)`	⬆️
packages/osd-std/src/index.ts	`92.30% <100.00%> (ø)`
packages/osd-ui-shared-deps/theme.ts	`41.66% <100.00%> (ø)`
src/cli_plugin/install/settings.js	`100.00% <100.00%> (ø)`
src/core/common/logos/get_logos.mock.ts	`100.00% <100.00%> (ø)`
src/core/public/chrome/chrome_service.mock.ts	`100.00% <ø> (ø)`
src/core/public/chrome/chrome_service.tsx	`91.42% <100.00%> (-0.24%)`	⬇️
...c/core/public/chrome/ui/header/collapsible_nav.tsx	`95.45% <ø> (-0.07%)`	⬇️
src/core/public/chrome/ui/header/header.tsx	`75.00% <ø> (ø)`
... and 84 more

... and 409 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…roject#128) * feat: setup mechanism to register different implementation on query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization on error message and response Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless clause Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move some code to a util function Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…roject#126) Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…objects client wrapper (opensearch-project#230) * feat: add basic workspace saved objects client wrapper Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add unit test (#2) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update client wrapper Signed-off-by: tygao <tygao@amazon.com> * feat: init permission control in workspace plugin Signed-off-by: Lin Wang <wonglam@amazon.com> * Support disable permission check on workspace (opensearch-project#228) * support disable permission check for workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix typos Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> * feat: add ACLSearchParams consumer in repository (#3) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: ACLSearchParams missing in search dsl Signed-off-by: Lin Wang <wonglam@amazon.com> * test: add integration test for workspace saved objects client wrapper Signed-off-by: Lin Wang <wonglam@amazon.com> * style: add empty line under license Signed-off-by: Lin Wang <wonglam@amazon.com> * test: enable workspace permission control for integration tests Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add workspace into includeHiddenTypes (opensearch-project#249) * feat: add workspace into includeHiddenTypes of client wrapper and permission control client Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: hiddenType side effect Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix workspace client wrapper integration tests Signed-off-by: Lin Wang <wonglam@amazon.com> * add permissions fields to workspace CRUD APIs Signed-off-by: Lin Wang <wonglam@amazon.com> * Move WorkspacePermissionMode inside workspace plugin Signed-off-by: Lin Wang <wonglam@amazon.com> * Address pr comments Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove ACLSearchParams in public SavedObjectsFindOptions Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove lodash and Add default permissionModes Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: address concerns on ensureRawRequest (#4) * feat: address concerns on ensureRawRequest Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add check for empty array Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make find api backward compatible Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Update annotations and error Signed-off-by: Lin Wang <wonglam@amazon.com> * Add unit tests for worksapce saved objects client wrapper Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove getPrincipalsOfObjects in permission Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix permissionEnabled flag missed in workspace plugin setup test Signed-off-by: Lin Wang <wonglam@amazon.com> * Change back to Not Authorized error Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix unit tests for query_params and plugin setup Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix unittests in workspace server utils Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add workspacesSearchOperators to decouple ACLSearchParams Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update test cases Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test cases Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: omit defaultSearchOperator in public savedobjetcs client Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: omit workspacesSearchOperator field Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Lin Wang <wonglam@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>

ruanyl and others added 30 commits August 3, 2023 17:21

setup workspace plugin project skeleton

912b6d2

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

test: add unit tests

b774c50

add license header Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

workspace template init commit

56a314c

Signed-off-by: Hailong Cui <ihailong@amazon.com>

refacter workspace template into hooks

327498c

Signed-off-by: Hailong Cui <ihailong@amazon.com>

refacter workspace template hooks

ff1645a

Signed-off-by: Hailong Cui <ihailong@amazon.com>

update coverImage comments

f1d0a35

Signed-off-by: Hailong Cui <ihailong@amazon.com>

feature: add public/workspaces service

168ba7f

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: add interfaces for workspaces client

7d3f24c

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: add interfaces for workspaces client

c6f9a47

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: add interfaces for workspaces client

e82777f

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: implement workspaces service

2c96331

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: changes to client type interface

5ec3feb

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: changes to client implement

0477076

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: implement more for workspaces service

0c07b79

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: implement more for workspaces service

7767933

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: implement more for workspaces service

ef1a245

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: use BehaviorObject and optimize code (#14)

a21d0c2

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: integrate with workspace create API (#13)

e9b5c3b

* feat: integrate with workspace create API Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: update to i18n text for toast Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>

register plugin with workspace template (#16)

5074400

Signed-off-by: Hailong Cui <ihailong@amazon.com>

workspace dropdown list (#9)

cf16249

Add workspace dropdown list --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> Co-authored-by: SuZhoue-Joe <suzhou@amazon.com>

Fix template registration import error (opensearch-project#21)

d7e740b

* fix import error Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix osd bootstrap failure Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>

feat: navigate to workspace create page after button clicked (opensea…

43c1bb6

…rch-project#23) Signed-off-by: Lin Wang <wonglam@amazon.com>

SuZhou-Joe force-pushed the fix/cypress branch from 8ad9aa5 to f5ac4fc Compare September 6, 2023 11:11

refactor: derive currentWorkspace in workspaces_service (opensearch-p…

56c8971

…roject#126) Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

SuZhou-Joe force-pushed the fix/cypress branch from 43c4767 to fa2efff Compare September 7, 2023 01:44

Hailong-am and others added 14 commits September 7, 2023 16:18

fix: cypress test

3cfa379

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: some unit test

4d97b57

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: unit test error group 2

6d57bbc

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: unit test group 4

5fa0515

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: bootstrap error

b4b68c3

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: cypress url error

1aec64a

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: functional test

a997151

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: route error

4580872

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: failed test

2773a74

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: test link

670375e

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: nuse navigateToApp when clickOpenSearchDashboardsSavedObjects

d0e13ea

feat: direct jump to specific page

152be06

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: snapshot

01c09c5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe force-pushed the fix/cypress branch from 4b4e90c to 01c09c5 Compare September 8, 2023 08:52

SuZhou-Joe added 4 commits September 8, 2023 17:39

feat: always register all library under library category

49b5cfa

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update management related path

9ef5867

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: doMock error

551e40c

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update snapshot

5e9a3f9

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe added a commit that referenced this pull request Oct 17, 2023

feat: add unit test (#2)

d9b5890

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe force-pushed the workspace branch from afa373a to dc240eb Compare February 23, 2024 01:39

SuZhou-Joe added a commit that referenced this pull request Mar 1, 2024

feat: add unit test (#2)

fbea16a

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe added a commit that referenced this pull request Mar 5, 2024

feat: add unit test (#2)

ab7c1ca

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/cypress #2

Fix/cypress #2

SuZhou-Joe commented Sep 6, 2023 •

edited

Loading

codecov-commenter commented Sep 6, 2023 •

edited

Loading

Fix/cypress #2

Are you sure you want to change the base?

Fix/cypress #2

Conversation

SuZhou-Joe commented Sep 6, 2023 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented Sep 6, 2023 • edited Loading

Codecov Report

SuZhou-Joe commented Sep 6, 2023 •

edited

Loading

codecov-commenter commented Sep 6, 2023 •

edited

Loading