Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Setup CI for Submerged #162

Closed
wants to merge 14 commits into from
Closed

Conversation

AmongUsafk
Copy link

hi @Alexejhero ,

Related to #149

this pr Implements CI workflow and adds build data file as specified.

  • Adds a new GitHub Actions workflow file ci.yml to automate the build process, including steps for restoring NuGet packages, building the mod in both debug and release configurations, and uploading the resulting DLLs as artifacts.
  • Introduces a build_data.json file containing the specified JSON structure for build path and dependencies, including download links and paths for BepInEx and Reactor dependencies.

if there any thing to change or something else feel free to ask me to do it

Alexejhero and others added 10 commits March 25, 2024 04:05
Related to SubmergedAmongUs#149

Implements CI workflow and adds build data file as specified.
- Adds a new GitHub Actions workflow file `ci.yml` to automate the build process, including steps for restoring NuGet packages, building the mod in both debug and release configurations, and uploading the resulting DLLs as artifacts.
- Introduces a `build_data.json` file containing the specified JSON structure for build path and dependencies, including download links and paths for BepInEx and Reactor dependencies.

---
Implement the Setup CI for Submerged
@CLAassistant
Copy link

CLAassistant commented May 17, 2024

CLA assistant check
All committers have signed the CLA.

@Alexejhero
Copy link
Member

Alexejhero commented May 17, 2024

Thank you so much for the contribution! I'll take a look at this sometime next week. Please remind me if I don't.

@Alexejhero Alexejhero added the enhancement New feature or request label May 17, 2024
@Alexejhero Alexejhero self-requested a review May 17, 2024 14:32
@AmongUsafk
Copy link
Author

AmongUsafk commented May 17, 2024

Thank you so much for the contribution! I'll take a look at this sometime next week. Please remind me if I don't.

no problem man i really love the project so much and i will remind you next week if u forgot

@AmongUsafk
Copy link
Author

and a lot of contribution is coming soon

@AmongUsafk AmongUsafk changed the title Related to issue #149 Add Setup CI for Submerged Add Setup CI for Submerged May 17, 2024
Copy link
Member

@Alexejhero Alexejhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is not finished yet, automating release artifacts hasn't been implemented. I won't be merging this in until that is added.

@Alexejhero Alexejhero marked this pull request as draft May 18, 2024 09:57
@AmongUsafk
Copy link
Author

This pull request is not finished yet, automating release artifacts hasn't been implemented. I won't be merging this in until that is added.

ok i will do that

GameTechGuides added 4 commits May 18, 2024 11:21
Implement automation for releasing artifacts.

- Add steps in `.github/workflows/ci.yml` to create a draft release and upload debug and release artifacts using GitHub Actions `actions/create-release@v1` and `actions/upload-release-asset@v1`.
Improve CI build process and project dependencies management.

- **CI Workflow Enhancements:**
  - Adds a step to set up environment variables before restoring dependencies, ensuring a consistent build environment.
  - Modifies both Debug and Release build steps to include error handling, allowing the build to proceed even if errors are encountered.
  - Introduces a step to check for untracked files necessary for compilation, improving build reliability.

- **Project Dependency Updates:**
  - Adds `Microsoft.Extensions.Configuration.Json` and `Microsoft.Extensions.Configuration.EnvironmentVariables` package references to manage app settings and environment variables more effectively.

These changes aim to address CI build errors and align local development environments with CI environments, ensuring successful builds across different setups.
@AmongUsafk
Copy link
Author

i have added automating release artifacts but i have a problem in the phase of dotnet build it give 859 error i checked the project is restored if u a know a fix tell me

Copy link
Member

@Alexejhero Alexejhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, the CI should work as described here. This is different.

@Alexejhero
Copy link
Member

i have added automating release artifacts but i have a problem in the phase of dotnet build it give 859 error i checked the project is restored if u a know a fix tell me

That's a good point, I guess CI is not possible without adding secrets due to #141. I think I'd wait for #141 to be resolved before adding CI.

@AmongUsafk
Copy link
Author

i have added automating release artifacts but i have a problem in the phase of dotnet build it give 859 error i checked the project is restored if u a know a fix tell me

That's a good point, I guess CI is not possible without adding secrets due to #141. I think I'd wait for #141 to be resolved before adding CI.

ok then when the #141 is fixed tell me to fix the ci

@Alexejhero
Copy link
Member

Closing this for now, #141 has a very low chance of being resolved in the near future

@Alexejhero Alexejhero closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants