You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most of the conversation already happened in the original PR.
Hm. SQLObject tbh seems a lot more complicated, and even though I don't expect us to go above 1000 feedback entries a year, it might be a pain to port those to be SQLObjects eventually, and I don't know how well Redis will scale / when it will need to be ported (I expect Redis will scale pretty well actually, but the pickling might slow things down). SQLObjects also seem to be more in line with other types of ORMs, but we don't need an ORM: we need a write once, read a few times sort of thing. Wrapping that in 2-3 functions that just execute SQL (create the table, add an entry, and get a list or subset of entries) matches how this interview will access the DB info a lot closer, and I've done a ton of similar things in the EFSP server, so I might try for that implementation.
We'll need something similar for the thumbs-up/down feedback thing in the toolkit too probably. I might put this on hold until I get something ready for that feature, and then change this to use that feature as well.
I think you're right, just directly using the SQL queries might be better. Just use SQLAlchemy or a similar SQL frontend tool for the features that help prevent SQL injection, but we don't need to map it to an object.
The text was updated successfully, but these errors were encountered:
In anticipation of scaling better with thousands of feedback items.
The only significant change is to change the GUID to a normal, incrementing SQL int id. GUID isn't a SQL standard thing (only a postgres thing), and tbh we don't get too much from it, so the flexibility of working with other dbs is probably better than keeping it.
Fixes#14.
Most of the conversation already happened in the original PR.
The text was updated successfully, but these errors were encountered: