Changed session backend to use SQLAlchemy #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonprofittechy
approved these changes
Jul 21, 2022
Since this is the refactor PR
BryceStevenWilley
force-pushed
the
sql_feedback
branch
from
d935d5d
to
0fb5f96
Compare
|
Final test that things worked. I also named some of the functions to better reflect they're about general feedback (not only session-tied feedback), and separated out the on-server feedback functions from the github ones, should have done that from the beginning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation of scaling better with thousands of feedback items.
The only significant change is to change the GUID to a normal, incrementing SQL int id. GUID isn't a SQL standard thing (only a postgres thing), and tbh we don't get too much from it, so the flexibility of working with other dbs is probably better than keeping it.
Fixes #14.