Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics)!: disable remote write proxy access logs by default #3071

Merged
merged 1 commit into from
May 30, 2023

Conversation

swiatekm
Copy link

We've decided this is the better default, as the logs aren't useful for much other than debugging connectivity problems, and there's a fair amount of them.

This is an example of a rare breaking change that will happen without a major version bump. Users who want the old behaviour can just re-enable it in their configuration.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@swiatekm swiatekm requested a review from a team as a code owner May 29, 2023 14:40
@github-actions github-actions bot added the documentation documentation label May 29, 2023
@sumo-drosiek
Copy link
Contributor

please fix markdownlint

@swiatekm swiatekm force-pushed the feat/remote-write-proxy-logs-default branch from 76e7e9f to ebb892c Compare May 30, 2023 09:17
@swiatekm swiatekm enabled auto-merge (rebase) May 30, 2023 09:17
@swiatekm swiatekm merged commit 8c703de into main May 30, 2023
@swiatekm swiatekm deleted the feat/remote-write-proxy-logs-default branch May 30, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants